[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

["kirktrue (via GitHub)" <gi...@apache.org>]

kirktrue commented on PR #13591:
URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581356873

   @jolshan The more I look at the code, the more I dislike it. Having the extra `CallingThread` parameter to distinguish application threads from the `Sender` thread is just... ugly.
   
   What do you think about storing a `Thread` reference or creating a `ThreadLocalData` in `TransactionManager`? That way the `Sender` can inform `TransactionManager` which thread it's using and we can eliminate all of that noise.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org