You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/06/13 00:35:09 UTC

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24455


Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................

IMPALA-15099: Fix SLES15 container build

The SLES15 container build is failing, because it is
unable to find the Python headers. We install Python 2,
but it is looking for /usr/include/python3.6m/Python.h.
Since we don't need Python 2 anymore, this switches to
the builtin python3 / python3-devel packages, which
fixes the issue.

Testing:
 - Built SLES15 container

Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
---
M docker/sles15.df
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/55/24455/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24455 )

Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24455/1/docker/sles15.df
File docker/sles15.df:

http://gerrit.cloudera.org:8080/#/c/24455/1/docker/sles15.df@49
PS1, Line 49:   java-1_8_0-openjdk-devel
Can we switch to Java 17 now as well? Then we could skip this and the next step.



-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2026 16:15:13 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24455 )

Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24455/1/docker/sles15.df
File docker/sles15.df:

http://gerrit.cloudera.org:8080/#/c/24455/1/docker/sles15.df@49
PS1, Line 49:   java-1_8_0-openjdk-devel
> Can we switch to Java 17 now as well? Then we could skip this and the next 
We usually share the containers with other older branches, so I wanted to leave the existing ones at Java 8 for now. We should think about making a clean break and moving everything to Java 17 with a separate set of images.



-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2026 16:46:08 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24455 )

Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jun 2026 19:17:36 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24455 )

Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jun 2026 15:23:39 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24455 )

Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................

IMPALA-15099: Fix SLES15 container build

The SLES15 container build is failing, because it is
unable to find the Python headers. We install Python 2,
but it is looking for /usr/include/python3.6m/Python.h.
Since we don't need Python 2 anymore, this switches to
the builtin python3 / python3-devel packages, which
fixes the issue.

Testing:
 - Built SLES15 container

Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Reviewed-on: http://gerrit.cloudera.org:8080/24455
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Yida Wu <wy...@gmail.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M docker/sles15.df
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Yida Wu: Looks good to me, but someone else must approve
  Laszlo Gaal: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[native-toolchain-CR] IMPALA-15099: Fix SLES15 container build

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24455 )

Change subject: IMPALA-15099: Fix SLES15 container build
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60619a5ead3b05a58f5317567ec92542e92fa683
Gerrit-Change-Number: 24455
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 15 Jun 2026 17:12:20 +0000
Gerrit-HasComments: No