You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/06/01 16:27:41 UTC

[GitHub] [solr] cpoerschke opened a new pull request, #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

cpoerschke opened a new pull request, #886:
URL: https://github.com/apache/solr/pull/886

   https://issues.apache.org/jira/browse/SOLR-16142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] cpoerschke merged pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

Posted by GitBox <gi...@apache.org>.
cpoerschke merged PR #886:
URL: https://github.com/apache/solr/pull/886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on PR #886:
URL: https://github.com/apache/solr/pull/886#issuecomment-1143876246

   > ... getDependentFields("spatial")` logic which might break if the `spatial.` prefix is simply dropped? ...
   
   okay, so experimentally, when the `spatial` checkbox is unchecked then it continues to send the spatial parameters and presumably it's not meant to do that.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on PR #886:
URL: https://github.com/apache/solr/pull/886#issuecomment-1143855301

   Perhaps last minute candidate for 8.11.2 if this fix is accurate? cc/fyi @madrob 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on PR #886:
URL: https://github.com/apache/solr/pull/886#issuecomment-1143867832

   Hmm, I'm not very familiar with this code but from trying to learn via the #122 diff there is I see at https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/webapp/web/js/angular/controllers/query.js#L145 some ` getDependentFields("spatial")` logic which might break if the `spatial.` prefix is simply dropped? So change/fix might be a little more involved?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on PR #886:
URL: https://github.com/apache/solr/pull/886#issuecomment-1143908205

   > okay, digging in some more
   
   so amending the `purgeParams` calls works I think, making the `spatial` checkbox similar to the `dismax` and `edismax` dropdown options. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

Posted by GitBox <gi...@apache.org>.
epugh commented on PR #886:
URL: https://github.com/apache/solr/pull/886#issuecomment-1143868787

   okay, digging in some more


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org