You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/10 04:06:46 UTC
Review Request 12394: Print default when no cluster exists
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Print a dash character, '-', when a resource has no cluster. Right now it renders blank space.
Diffs
-----
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
Diff: https://reviews.apache.org/r/12394/diff/
Testing
-------
Rendered each page with a potentially blank cluster.
Thanks,
Ross Allen
Re: Review Request 12394: Print default when no cluster exists
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review23019
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 11, 2013, 12:34 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 11, 2013, 12:34 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print a dash character, '-', when a resource has no cluster. Right now it renders blank space.
>
>
> Diffs
> -----
>
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ben Mahler <be...@gmail.com>.
> On July 15, 2013, 10:43 p.m., Ben Mahler wrote:
> > Ship It!
Committed!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review23186
-----------------------------------------------------------
On July 12, 2013, 10:17 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:17 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> File Attachments
> ----------------
>
> Unnamed default state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
> Unnamed hover state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review23186
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 12, 2013, 10:17 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:17 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> File Attachments
> ----------------
>
> Unnamed default state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
> Unnamed hover state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/
-----------------------------------------------------------
(Updated July 12, 2013, 10:17 p.m.)
Review request for mesos.
Changes
-------
Update toolip wording to "To name this cluster, set the --cluster flag when starting the master." per review.
Repository: mesos
Description
-------
Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
Diffs (updated)
-----
src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
Diff: https://reviews.apache.org/r/12394/diff/
Testing
-------
Rendered each page with a potentially blank cluster.
File Attachments
----------------
Unnamed default state
https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
Unnamed hover state
https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
Thanks,
Ross Allen
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 12, 2013, 9:52 p.m., Ben Mahler wrote:
> > src/webui/master/static/home.html, line 30
> > <https://reviews.apache.org/r/12394/diff/2/?file=320943#file320943line30>
> >
> > Can you mention that this is a flag on the master? Having this on the slave pages might lead some to think it's a slave flag.
> >
> > E.g.
> >
> > "To name this cluster, set the --cluster flag when starting the master."
Can do.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review23100
-----------------------------------------------------------
On July 12, 2013, 9:35 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 9:35 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> File Attachments
> ----------------
>
> Unnamed default state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
> Unnamed hover state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 12, 2013, 9:52 p.m., Ben Mahler wrote:
> > src/webui/master/static/home.html, line 30
> > <https://reviews.apache.org/r/12394/diff/2/?file=320943#file320943line30>
> >
> > Can you mention that this is a flag on the master? Having this on the slave pages might lead some to think it's a slave flag.
> >
> > E.g.
> >
> > "To name this cluster, set the --cluster flag when starting the master."
>
> Ross Allen wrote:
> Can do.
Ben, do you mind committing this for me? The change you requested is in this diff now and ready to roll.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review23100
-----------------------------------------------------------
On July 12, 2013, 10:17 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:17 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> File Attachments
> ----------------
>
> Unnamed default state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
> Unnamed hover state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review23100
-----------------------------------------------------------
Ship it!
src/webui/master/static/home.html
<https://reviews.apache.org/r/12394/#comment46909>
Can you mention that this is a flag on the master? Having this on the slave pages might lead some to think it's a slave flag.
E.g.
"To name this cluster, set the --cluster flag when starting the master."
- Ben Mahler
On July 12, 2013, 9:35 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 9:35 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> File Attachments
> ----------------
>
> Unnamed default state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
> Unnamed hover state
> https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/
-----------------------------------------------------------
(Updated July 12, 2013, 9:35 p.m.)
Review request for mesos.
Changes
-------
Add some screenshots and update the description to match changes.
Repository: mesos
Description (updated)
-------
Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is not used.
Diffs
-----
src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
Diff: https://reviews.apache.org/r/12394/diff/
Testing
-------
Rendered each page with a potentially blank cluster.
File Attachments (updated)
----------------
Unnamed default state
https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png
Unnamed hover state
https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png
Thanks,
Ross Allen
Re: Review Request 12394: Print default when cluster is unnamed
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/
-----------------------------------------------------------
(Updated July 12, 2013, 9:33 p.m.)
Review request for mesos.
Summary (updated)
-----------------
Print default when cluster is unnamed
Repository: mesos
Description
-------
Print a dash character, '-', when a resource has no cluster. Right now it renders blank space.
Diffs (updated)
-----
src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
Diff: https://reviews.apache.org/r/12394/diff/
Testing
-------
Rendered each page with a potentially blank cluster.
Thanks,
Ross Allen
Re: Review Request 12394: Print default when no cluster exists
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/
-----------------------------------------------------------
(Updated July 11, 2013, 12:34 a.m.)
Review request for mesos.
Repository: mesos
Description
-------
Print a dash character, '-', when a resource has no cluster. Right now it renders blank space.
Diffs
-----
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
Diff: https://reviews.apache.org/r/12394/diff/
Testing
-------
Rendered each page with a potentially blank cluster.
Thanks,
Ross Allen
Re: Review Request 12394: Print default when no cluster exists
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 7:25 p.m., Ben Mahler wrote:
> > Was there a rendering issue? Would users know why a dash is present there?
> > Ultimately, it would be awesome if we can make it clear that they haven't specified the --cluster flag in the master.
> >
> > What if we add a hover that mentions the --cluster flag? We could display "(unnamed cluster)" or the like..
It looked odd having empty space to the right of "Cluster:" when --cluster was not used. I like your idea of a more meaningful default than '-' though with maybe a tooltip mentioning the use of the --cluster flag.
I will make some changes.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review22967
-----------------------------------------------------------
On July 10, 2013, 2:06 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 2:06 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print a dash character, '-', when a resource has no cluster. Right now it renders blank space.
>
>
> Diffs
> -----
>
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12394: Print default when no cluster exists
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12394/#review22967
-----------------------------------------------------------
Was there a rendering issue? Would users know why a dash is present there?
Ultimately, it would be awesome if we can make it clear that they haven't specified the --cluster flag in the master.
What if we add a hover that mentions the --cluster flag? We could display "(unnamed cluster)" or the like..
- Ben Mahler
On July 10, 2013, 2:06 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12394/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 2:06 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print a dash character, '-', when a resource has no cluster. Right now it renders blank space.
>
>
> Diffs
> -----
>
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
>
> Diff: https://reviews.apache.org/r/12394/diff/
>
>
> Testing
> -------
>
> Rendered each page with a potentially blank cluster.
>
>
> Thanks,
>
> Ross Allen
>
>