[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12710: Enhance protobuf builder logs

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #12710:
URL: https://github.com/apache/dubbo/pull/12710#discussion_r1259163207


##########
dubbo-metadata/dubbo-metadata-definition-protobuf/src/main/java/org/apache/dubbo/metadata/definition/protobuf/ProtobufTypeBuilder.java:
##########
@@ -48,6 +48,8 @@ public class ProtobufTypeBuilder implements TypeBuilder, Prioritized {
      */
     private static Type STRING_LIST_TYPE;
 
+    private final boolean protobufExist;

Review Comment:
   In a multi-class loader scenario, static may cause class loading exceptions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org