You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "LeoWoerteler (via GitHub)" <gi...@apache.org> on 2023/08/10 10:06:47 UTC
[GitHub] [cxf] LeoWoerteler opened a new pull request, #1377: [CXF-8885] Eliminate hidden reference to `HttpClient` in `ProxySelector`
LeoWoerteler opened a new pull request, #1377:
URL: https://github.com/apache/cxf/pull/1377
The SelectorManager thread of the WebClient would normally shut down after the HttpClient's outer shell, the `HttpClientFacade` has been garbage collected. Unfortunately the `ProxySelector` instance created in `HttpClientHTTPConduit` is a non-static (anonymous) subclass, so it retains a hard reference to the enclosing `HttpClientHTTPConduit` instance and therefore also its `client` field. This gives the SelectorManager thread a hard reference to the `HttpClientFacade`, so the facade can never be garbage collected and the thread never shuts down. Making the class static solves the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #1377: [CXF-8885] Eliminate hidden reference to `HttpClient` in `ProxySelector`
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #1377:
URL: https://github.com/apache/cxf/pull/1377#issuecomment-1674057064
Thank you @LeoWoerteler !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta merged pull request #1377: [CXF-8885] Eliminate hidden reference to `HttpClient` in `ProxySelector`
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta merged PR #1377:
URL: https://github.com/apache/cxf/pull/1377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cachescrubber commented on pull request #1377: [CXF-8885] Eliminate hidden reference to `HttpClient` in `ProxySelector`
Posted by "cachescrubber (via GitHub)" <gi...@apache.org>.
cachescrubber commented on PR #1377:
URL: https://github.com/apache/cxf/pull/1377#issuecomment-1674378781
Thank you @LeoWoerteler, I just verified the fix in my reproducible example:
https://github.com/cachescrubber/cxf-8885-demo/commit/fda7c8a5248689357f76effe200b34f38fa83126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org