You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/06 00:19:54 UTC

[GitHub] [incubator-superset] nytai opened a new pull request #9250: [webpack] fix copying images when running dev server

nytai opened a new pull request #9250: [webpack] fix copying images when running dev server
URL: https://github.com/apache/incubator-superset/pull/9250
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   There's currently an issue with the copy-webpack-plugin (used for copying images and stylesheets) 
   that doesn't play nicely with clean-webpack-plugin. This is only an issue when running the dev server and only occurs after a rebuild. 
   
   more info here: https://github.com/webpack-contrib/copy-webpack-plugin/issues/261#issuecomment-552550859
   
   This PR introduces a config option to force the plugin to always copy the assets, even if they're unchanged. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @suddjian @etr2460 @kristw 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 merged pull request #9250: [webpack] fix copying images when running dev server

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9250: [webpack] fix copying images when running dev server
URL: https://github.com/apache/incubator-superset/pull/9250
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org