[GitHub] [iceberg] kbendick commented on a change in pull request #3624: Build: Append _2.12 (scala version) to Spark 3.1 and 3.2 module names

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3624:
URL: https://github.com/apache/iceberg/pull/3624#discussion_r758835385



##########
File path: jmh.gradle
##########
@@ -33,7 +33,7 @@ if (sparkVersions.contains("3.0")) {
 }
 
 if (sparkVersions.contains("3.2")) {
-  jmhProjects.add(project(":iceberg-spark:iceberg-spark-3.2"))
+  jmhProjects.add(project(":iceberg-spark:iceberg-spark-3.2_2.12"))

Review comment:
       Oh here I mean that it's presently possible to run JMH tests on Spark 3.0 and Spark 3.2, but not Spark 3.1.
   
   Adding Spark 3.1 support to the JMH tests feels orthogonal to adding Scala versioning.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org