You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/22 00:47:28 UTC
Review Request 64792: Fixed a bug where quota headroom is tracked
incorrectly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64792/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Fixed a bug where quota headroom is tracked incorrectly.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 7f7dae1950bebd22191189c2db0f6678d2e8fa3c
Diff: https://reviews.apache.org/r/64792/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 64792: Fixed a bug where quota headroom is tracked
incorrectly.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64792/#review194387
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Dec. 22, 2017, 12:47 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64792/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 12:47 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only resources allocated towards a role's quota should be
> subtracted from `requiredHeadroom`. In addition to this,
> unreserved resources in the quota allocation stage may also
> contain resources that a role does not have quota for, they
> should not be subtracted from `requiredHeadroom`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 7f7dae1950bebd22191189c2db0f6678d2e8fa3c
>
>
> Diff: https://reviews.apache.org/r/64792/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>