You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/07 18:23:59 UTC

[GitHub] [kafka] rayokota commented on pull request #12126: KAFKA-8713 KIP-581: Add new conf serialize.accept.optional.null in connect-json

rayokota commented on PR #12126:
URL: https://github.com/apache/kafka/pull/12126#issuecomment-1178039321

   The fix is not quite correct.  You need to conditionally call `struct.getWithoutDefault(field.name())`.  You should also add a test using a struct.  See the corresponding fix for the JSON Schema converter in https://github.com/confluentinc/schema-registry/pull/2326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org