You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/09/23 09:54:02 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #3526: [ISSUE-3400][shell]errorcode code optimization
binbinCheng opened a new pull request, #3526:
URL: https://github.com/apache/incubator-linkis/pull/3526
**[shell]errorcode code optimization**
Related issues: #3400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3526: [ISSUE-3400][shell]errorcode code optimization
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3526:
URL: https://github.com/apache/incubator-linkis/pull/3526#issuecomment-1256049863
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3526?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3526](https://codecov.io/gh/apache/incubator-linkis/pull/3526?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20e0678) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/46afeb87120f7a589f2e0323769cd91dea985584?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46afeb8) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3526 +/- ##
============================================
Coverage 14.27% 14.27%
- Complexity 1255 1256 +1
============================================
Files 820 821 +1
Lines 31618 31636 +18
Branches 4679 4679
============================================
+ Hits 4512 4516 +4
- Misses 26453 26466 +13
- Partials 653 654 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3526?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...shell/errorcode/LinkisCommonsErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL21hbmFnZXIvZW5naW5lcGx1Z2luL3NoZWxsL2Vycm9yY29kZS9MaW5raXNDb21tb25zRXJyb3JDb2RlU3VtbWFyeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...kis/engineplugin/spark/SparkEngineConnPlugin.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvU3BhcmtFbmdpbmVDb25uUGx1Z2luLnNjYWxh) | `0.00% <0.00%> (-27.78%)` | :arrow_down: |
| [...apache/linkis/scheduler/queue/SchedulerEvent.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvU2NoZWR1bGVyRXZlbnQuc2NhbGE=) | `50.00% <0.00%> (ø)` | |
| [...lugin/spark/executor/SparkEngineConnExecutor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvZXhlY3V0b3IvU3BhcmtFbmdpbmVDb25uRXhlY3V0b3Iuc2NhbGE=) | `30.07% <0.00%> (+0.75%)` | :arrow_up: |
| [.../scala/org/apache/linkis/scheduler/queue/Job.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvSm9iLnNjYWxh) | `15.28% <0.00%> (+0.87%)` | :arrow_up: |
| [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `32.72% <0.00%> (+1.81%)` | :arrow_up: |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `38.67% <0.00%> (+1.88%)` | :arrow_up: |
| [...a/org/apache/linkis/scheduler/queue/Consumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvQ29uc3VtZXIuc2NhbGE=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
| [...la/org/apache/linkis/scheduler/queue/UserJob.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3526/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvVXNlckpvYi5zY2FsYQ==) | `33.33% <0.00%> (+16.66%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #3526: [ISSUE-3400][shell]errorcode code optimization
Posted by GitBox <gi...@apache.org>.
peacewong commented on code in PR #3526:
URL: https://github.com/apache/incubator-linkis/pull/3526#discussion_r991882302
##########
linkis-engineconn-plugins/shell/src/main/java/org/apache/linkis/manager/engineplugin/shell/errorcode/LinkisCommonsErrorCodeSummary.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.manager.engineplugin.shell.errorcode;
+
+public enum LinkisCommonsErrorCodeSummary {
Review Comment:
Rename class name LinkisShellECErrorCodeSummary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3526: [ISSUE-3400][shell]errorcode code optimization
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3526:
URL: https://github.com/apache/incubator-linkis/pull/3526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org