You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jeremy Whitlock <jc...@gmail.com> on 2008/08/25 18:40:15 UTC
[PATCH] Fix the 'test_create' SWIG Python Repository Test to Not Create Nested Repositories
Hi All,
As of r32648, Subversion will not allow you to create a repository
within a repository. When this change was made, the test_create test
in subversion/bindings/swig/python/tests/repository.py began failing,
because it was trying to create a repository within REPOS_PATH, which
was a repository. The attached patch will fix this problem allowing
all Python tests to run successfully. (This patch was created from
the 1.5.x branch.)
--
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
Re: [PATCH] Fix the 'test_create' SWIG Python Repository Test to
Not Create Nested Repositories
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Jeremy Whitlock wrote on Mon, 25 Aug 2008 at 13:25 -0600:
> > +1; do you have commit access? Be sure you don't commit it
> > directly to 1.5.x :).
>
> I do have partial commit access. If it wouldn't be "overstepping my
> bounds", I'd love to commit it.
Sure, you can commit, just make sure to put
Approved by: epg
in the log message. (See HACKING for the details.)
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix the 'test_create' SWIG Python Repository Test to Not Create Nested Repositories
Posted by Jeremy Whitlock <jc...@gmail.com>.
> +1; do you have commit access? Be sure you don't commit it
> directly to 1.5.x :).
I do have partial commit access. If it wouldn't be "overstepping my
bounds", I'd love to commit it. (I'd even make sure *not* to commit
it to the 1.5.x branch. :P) I think Hyrum might want to chime in
though. (There is a minor change that might need to be made.
tempfile.mktemp is deprecated and I used it. The reason behind using
it was we use that in other places in the Python sources and I wanted
to keep some commonality. I could very easily use tempfile.mkdtemp
but if we fix it here, we should probably update the other places
where we use the deprecated method.)
--
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix the 'test_create' SWIG Python Repository Test to Not Create Nested Repositories
Posted by Eric Gillespie <ep...@pretzelnet.org>.
"Jeremy Whitlock" <jc...@gmail.com> writes:
> was a repository. The attached patch will fix this problem allowing
> all Python tests to run successfully. (This patch was created from
> the 1.5.x branch.)
+1; do you have commit access? Be sure you don't commit it
directly to 1.5.x :).
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org