You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/14 11:29:14 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new issue, #42: Restore the removed text from handling-blocking-operations-in-pekko-http-routes.md
mdedetrich opened a new issue, #42:
URL: https://github.com/apache/incubator-pekko-http/issues/42
In the https://github.com/apache/incubator-pekko-http/pull/34 PR, specific markdown text was removed from the `handling-blocking-operations-in-pekko-http-routes.md` file, i.e. https://github.com/apache/incubator-pekko-http/pull/34/files/38af0a2735a3cdf5339490d5f1d3acd910cc65a5#diff-6ff1d12760e28d4b30391860625c906ad82391240593ad8dabd7e93e2c7b571aL69 . Incase you have issues viewing the diff the precise text that was removed is
```
@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
```
after the `however they go to sleep state immediately, thus wasting the resources.` sentance.
The reason why the text was removed was that due to the change in that PR in renaming the package from `akka` to `org.apache.pekko`, it caused paradox to make a compilation error on that text. Even when trying to use a FQCN i.e.
```
@java[The same happens to the global @apidoc[java.util.concurrent.ForkJoinPool] when using Java Futures.]
```
It still didn't compile. I suspect that the root cause is before the package name change, some weird shadowing was going on with the `akka` package, and because of this the `@apidoc[ForkJoinPool]` was actually pointing to `akka.dispatch.forkjoin.ForkJoinPool` and not `java.util.concurrent.ForkJoinPool` (which I think is incorrect judging from the context of whats being described).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich closed issue #42: Restore the removed text from `handling-blocking-operations-in-pekko-http-routes.md`
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #42: Restore the removed text from `handling-blocking-operations-in-pekko-http-routes.md`
URL: https://github.com/apache/incubator-pekko-http/issues/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org