You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "nandakumar131 (via GitHub)" <gi...@apache.org> on 2025/01/07 14:15:00 UTC

[PR] HDDS-12034. Enable sortpom in hadoop-hdds-interface server, admin & client [ozone]

nandakumar131 opened a new pull request, #7660:
URL: https://github.com/apache/ozone/pull/7660

   ## What changes were proposed in this pull request?
   Enable sortpom in hadoop-hdds-interface server, admin & client
   
   Sortpom plugin was added as part of https://github.com/apache/ozone/pull/7555.
   This PR enables the plugin for hadoop-hdds sub-modules. (part 5)
   Sorting all the sub-modules under hadoop-hdds creates a big change, which will be hard to review. So, breaking this into multiple PRs.
   This PR sorts pom of the following sub-modules.
   
   - interface-server
   - interface-admin
   - interface-client
   
   ## What is the link to the Apache JIRA
   HDDS-12034
   
   ## How was this patch tested?
   
   Manually tested by adding out of order property.
   
   `hadoop-hdds/interface-server/pom.xml`
   ```
   [INFO] --- sortpom:3.0.1:verify (default) @ hdds-interface-server ---
   [INFO] Verifying file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/interface-server/pom.xml
   [ERROR] The line 31 is not considered sorted, should be '    <property.one>one</property.one>'
   [ERROR] The file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/interface-server/pom.xml is not sorted
   ```
   
   `hadoop-hdds/interface-admin/pom.xml`
   ```
   [INFO] --- sortpom:3.0.1:verify (default) @ hdds-interface-admin ---
   [INFO] Verifying file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/interface-admin/pom.xml
   [ERROR] The line 31 is not considered sorted, should be '    <property.one>one</property.one>'
   [ERROR] The file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/interface-admin/pom.xml is not sorted
   ```
   
   `hadoop-hdds/interface-client/pom.xml`
   ```
   [INFO] --- sortpom:3.0.1:verify (default) @ hdds-interface-client ---
   [INFO] Verifying file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/interface-client/pom.xml
   [ERROR] The line 31 is not considered sorted, should be '    <property.one>one</property.one>'
   [ERROR] The file /Users/nvadivelu/Codebase/Github/ozone/hadoop-hdds/interface-client/pom.xml is not sorted
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12034. Enable sortpom in hadoop-hdds-interface server, admin & client [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7660:
URL: https://github.com/apache/ozone/pull/7660#issuecomment-2576804738

   Thanks @adoroszlai for the review and merge!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12034. Enable sortpom in hadoop-hdds-interface server, admin & client [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on code in PR #7660:
URL: https://github.com/apache/ozone/pull/7660#discussion_r1906510541


##########
hadoop-hdds/interface-client/pom.xml:
##########
@@ -143,38 +132,21 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
         <version>${maven-antrun-plugin.version}</version>
         <executions>
           <execution>
+            <goals>
+              <goal>run</goal>
+            </goals>
             <phase>generate-sources</phase>
             <configuration>
               <target>
-                <replace token="com.google.protobuf"
-                         value="org.apache.ratis.thirdparty.com.google.protobuf"
-                         dir="target/generated-sources/java/org/apache/hadoop/hdds/protocol/datanode/proto">

Review Comment:
   Me too. The original format was easy to read.
   Let's revisit this once we move to the newer version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12034. Enable sortpom in hadoop-hdds-interface server, admin & client [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7660:
URL: https://github.com/apache/ozone/pull/7660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12034. Enable sortpom in hadoop-hdds-interface server, admin & client [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7660:
URL: https://github.com/apache/ozone/pull/7660#discussion_r1906454925


##########
hadoop-hdds/interface-client/pom.xml:
##########
@@ -143,38 +132,21 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
         <version>${maven-antrun-plugin.version}</version>
         <executions>
           <execution>
+            <goals>
+              <goal>run</goal>
+            </goals>
             <phase>generate-sources</phase>
             <configuration>
               <target>
-                <replace token="com.google.protobuf"
-                         value="org.apache.ratis.thirdparty.com.google.protobuf"
-                         dir="target/generated-sources/java/org/apache/hadoop/hdds/protocol/datanode/proto">

Review Comment:
   I find the original format more readable, but the option in `sortpom` to preserve this (`indentAttribute`) is available only in newer versions that do not support Java 8.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org