You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/09 01:45:27 UTC

[GitHub] [apisix] membphis commented on a change in pull request #2345: feat: Add lables for route/consumer/service/ssl objects

membphis commented on a change in pull request #2345:
URL: https://github.com/apache/apisix/pull/2345#discussion_r502127213



##########
File path: apisix/schema_def.lua
##########
@@ -555,6 +580,14 @@ _M.ssl = {
             type = "integer",
             minimum = 1588262400,  -- 2020/5/1 0:0:0
         },
+        labels = {

Review comment:
       > we could use label to distinguish among dozens of SSLs according to their usage.
   
   Agree this. Searching by category will be helpful.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org