You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/26 12:56:06 UTC
[GitHub] [superset] squalou opened a new issue #18177: When user is not logged in she gets an error instead of login button
squalou opened a new issue #18177:
URL: https://github.com/apache/superset/issues/18177
This is admittedly a corner case, somewhat.
A user has a bookmark to https://superset.mydomain.org/chart/list/
When she tries to access this page BUT is not logged in (maye she logged out, or changed browser or whatever),
she gets an awful error.
A probably better solution would be to redirect to https://superset.mydomain.org/superset/welcome
Note that "Login" works, it's just confusing users
#### How to reproduce the bug
1. Login
2. Go to https://superset.mydomain.org/chart/list/
3. Bookmark
4. Logout
5. Open bookmark
6. See error
### Expected results
redirection to the welcome page
### Actual results
Error message
#### Screenshots
### Environment
- browser type and version: Chrome linux 92 or Firefox 95
- superset version: `superset version` 1.4.0
- python version: `python --version` 3.8.12
- node.js version: `node -v` - not included in Docker image
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] squalou commented on issue #18177: When user is not logged in she gets an error instead of login button
Posted by GitBox <gi...@apache.org>.
squalou commented on issue #18177:
URL: https://github.com/apache/superset/issues/18177#issuecomment-1027639155
good news :)
I'll see what happens at next update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on issue #18177: When user is not logged in she gets an error instead of login button
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on issue #18177:
URL: https://github.com/apache/superset/issues/18177#issuecomment-1027563721
cant reproduce on master, it correctly shows access denied and redirects to login page while keeping intended url in next parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] squalou commented on issue #18177: When user is not logged in she gets an error instead of login button
Posted by GitBox <gi...@apache.org>.
squalou commented on issue #18177:
URL: https://github.com/apache/superset/issues/18177#issuecomment-1023635274
You're completely right, an annoyance, not a bug. Nice to have is fine.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on issue #18177: When user is not logged in she gets an error instead of login button
Posted by GitBox <gi...@apache.org>.
srinify commented on issue #18177:
URL: https://github.com/apache/superset/issues/18177#issuecomment-1023223385
Hey @squalou definitely not an ideal experience! But I will say this isn't strictly a "bug" because it's working as intended. If it's okay with you, I've added the "nice to have" label to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org