You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/06 16:21:07 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #2005: [NETBEANS-3968] Fix convert visibility hint for methods

junichi11 opened a new pull request #2005: [NETBEANS-3968] Fix convert visibility hint for methods
URL: https://github.com/apache/netbeans/pull/2005
 
 
   https://issues.apache.org/jira/browse/NETBEANS-3968
   
   1. Fix convert visibility hint for methods
   
   - Show hints for methods when the caret is only on the line that has visibility
   
   2. Lower the priority of convert visibility hint
   
   - When this hint is shown with other hints(e.g. Initialize Fields), we should lower order than the other hints because other hints are more important
   
   Priority
   
   ##### Before
   
   ![nb-3968-priority-before](https://user-images.githubusercontent.com/738383/76100874-cf301700-6010-11ea-83d8-b93a483271ac.png)
   
   ##### After
   
   ![nb-3968-priority-after](https://user-images.githubusercontent.com/738383/76100996-01da0f80-6011-11ea-8042-5b5d14eb862d.png)
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik merged pull request #2005: [NETBEANS-3968] Fix convert visibility hint for methods

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2005: [NETBEANS-3968] Fix convert visibility hint for methods
URL: https://github.com/apache/netbeans/pull/2005
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on issue #2005: [NETBEANS-3968] Fix convert visibility hint for methods

Posted by GitBox <gi...@apache.org>.
junichi11 commented on issue #2005: [NETBEANS-3968] Fix convert visibility hint for methods
URL: https://github.com/apache/netbeans/pull/2005#issuecomment-596399927
 
 
   @tmysik Yes, you can. Thank You!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on issue #2005: [NETBEANS-3968] Fix convert visibility hint for methods

Posted by GitBox <gi...@apache.org>.
tmysik commented on issue #2005: [NETBEANS-3968] Fix convert visibility hint for methods
URL: https://github.com/apache/netbeans/pull/2005#issuecomment-596383090
 
 
   @junichi11 
   
   Just to be sure - I can merge this PR right now, correct?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists