You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-commits@db.apache.org by mb...@apache.org on 2023/01/29 19:21:52 UTC
[db-jdo] branch JDO-823-3 created (now 56d38440)
This is an automated email from the ASF dual-hosted git repository.
mbo pushed a change to branch JDO-823-3
in repository https://gitbox.apache.org/repos/asf/db-jdo.git
at 56d38440 JDO-823: @Override should be used on verriding methods
This branch includes the following new commits:
new b815dfe4 JDO-823: Attributes deprecated in HTML 5 should not be used
new d500fdaa JDO-823: Synchronized classes StringBuffer and Hashtable should not be used
new 56d38440 JDO-823: @Override should be used on verriding methods
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[db-jdo] 02/03: JDO-823: Synchronized classes StringBuffer and Hashtable should not be used
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mbo pushed a commit to branch JDO-823-3
in repository https://gitbox.apache.org/repos/asf/db-jdo.git
commit d500fdaae97aa5f0cdd64f89563a65e889948d0b
Author: Michael Bouschen <Mi...@akquinet.de>
AuthorDate: Sun Jan 29 19:55:33 2023 +0100
JDO-823: Synchronized classes StringBuffer and Hashtable should not be used
---
api/src/main/java/javax/jdo/JDOException.java | 2 +-
api/src/main/java/javax/jdo/spi/I18NHelper.java | 7 ++++---
exectck/src/main/java/org/apache/jdo/exectck/Help.java | 2 +-
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java | 2 +-
exectck/src/main/java/org/apache/jdo/exectck/Utilities.java | 2 +-
5 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/api/src/main/java/javax/jdo/JDOException.java b/api/src/main/java/javax/jdo/JDOException.java
index ffdd51ad..50e03c61 100644
--- a/api/src/main/java/javax/jdo/JDOException.java
+++ b/api/src/main/java/javax/jdo/JDOException.java
@@ -195,7 +195,7 @@ public class JDOException extends java.lang.RuntimeException {
public synchronized String toString() {
int len = nested == null ? 0 : nested.length;
// calculate approximate size of the String to return
- StringBuffer sb = new StringBuffer(10 + 100 * len);
+ StringBuilder sb = new StringBuilder(10 + 100 * len);
sb.append(super.toString());
// include failed object information
if (failed != null) {
diff --git a/api/src/main/java/javax/jdo/spi/I18NHelper.java b/api/src/main/java/javax/jdo/spi/I18NHelper.java
index fa3ce235..11eff215 100644
--- a/api/src/main/java/javax/jdo/spi/I18NHelper.java
+++ b/api/src/main/java/javax/jdo/spi/I18NHelper.java
@@ -20,7 +20,8 @@ package javax.jdo.spi;
import java.lang.reflect.InvocationTargetException;
import java.security.PrivilegedAction;
import java.text.MessageFormat;
-import java.util.Hashtable;
+import java.util.HashMap;
+import java.util.Map;
import java.util.Locale;
import java.util.ResourceBundle;
import javax.jdo.JDOFatalInternalException;
@@ -50,10 +51,10 @@ import javax.jdo.LegacyJava;
public class I18NHelper {
/** Bundles that have already been loaded */
- private static final Hashtable<String, ResourceBundle> bundles = new Hashtable<>();
+ private static final Map<String, ResourceBundle> bundles = new HashMap<>();
/** Helper instances that have already been created */
- private static final Hashtable<String, I18NHelper> helpers = new Hashtable<>();
+ private static final Map<String, I18NHelper> helpers = new HashMap<>();
/** The default locale for this VM. */
private static final Locale locale = Locale.getDefault();
diff --git a/exectck/src/main/java/org/apache/jdo/exectck/Help.java b/exectck/src/main/java/org/apache/jdo/exectck/Help.java
index 88298b77..8a3abda2 100644
--- a/exectck/src/main/java/org/apache/jdo/exectck/Help.java
+++ b/exectck/src/main/java/org/apache/jdo/exectck/Help.java
@@ -29,7 +29,7 @@ public class Help extends AbstractMojo {
@Override
public void execute() throws MojoExecutionException, MojoFailureException {
- StringBuffer msg = new StringBuffer();
+ StringBuilder msg = new StringBuilder();
msg.append("\n\n*** jdo-exectck Maven plugin ***\n\n");
msg.append("This plugin executes the JDO Technology Compatibility Kit (TCK)\n");
diff --git a/exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java b/exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java
index beb8dfa1..a24bd431 100644
--- a/exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java
+++ b/exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java
@@ -383,7 +383,7 @@ public class RunTCK extends AbstractTCKMojo {
runonce = (runonce == null) ? "false" : runonce;
// Add Mapping and schemaname to properties file
- StringBuffer propsFileData = new StringBuffer();
+ StringBuilder propsFileData = new StringBuilder();
propsFileData.append("\n### Properties below added by maven 2 goal RunTCK.jdori");
propsFileData.append("\njavax.jdo.mapping.Schema=" + idtype + mapping);
mapping = (mapping.equals("0")) ? "" : mapping;
diff --git a/exectck/src/main/java/org/apache/jdo/exectck/Utilities.java b/exectck/src/main/java/org/apache/jdo/exectck/Utilities.java
index 6e0a49de..1d39c4c2 100644
--- a/exectck/src/main/java/org/apache/jdo/exectck/Utilities.java
+++ b/exectck/src/main/java/org/apache/jdo/exectck/Utilities.java
@@ -95,7 +95,7 @@ public class Utilities {
static String readFile(String fileName) throws IOException {
BufferedReader reader = new BufferedReader(new FileReader(fileName));
String line = null;
- StringBuffer stringBuf = new StringBuffer();
+ StringBuilder stringBuf = new StringBuilder();
String ls = System.getProperty("line.separator");
while ((line = reader.readLine()) != null) {
stringBuf.append(line);
[db-jdo] 03/03: JDO-823: @Override should be used on verriding methods
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mbo pushed a commit to branch JDO-823-3
in repository https://gitbox.apache.org/repos/asf/db-jdo.git
commit 56d384402b0deb844916f73493e7ee57d664a089
Author: Michael Bouschen <Mi...@akquinet.de>
AuthorDate: Sun Jan 29 20:02:36 2023 +0100
JDO-823: @Override should be used on verriding methods
---
api/src/main/java/javax/jdo/listener/InstanceLifecycleEvent.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/api/src/main/java/javax/jdo/listener/InstanceLifecycleEvent.java b/api/src/main/java/javax/jdo/listener/InstanceLifecycleEvent.java
index cffc6d81..ee3cbea5 100644
--- a/api/src/main/java/javax/jdo/listener/InstanceLifecycleEvent.java
+++ b/api/src/main/java/javax/jdo/listener/InstanceLifecycleEvent.java
@@ -107,6 +107,7 @@ public class InstanceLifecycleEvent extends java.util.EventObject {
* @see #getDetachedInstance()
* @see "Section 12.15, Java Data Objects 2.0 Specification"
*/
+ @Override
public Object getSource() {
return super.getSource();
}
[db-jdo] 01/03: JDO-823: Attributes deprecated in HTML 5 should not be used
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mbo pushed a commit to branch JDO-823-3
in repository https://gitbox.apache.org/repos/asf/db-jdo.git
commit b815dfe4548d60cd97aacafc6075578014e16ddc
Author: Michael Bouschen <Mi...@akquinet.de>
AuthorDate: Sun Jan 29 19:44:14 2023 +0100
JDO-823: Attributes deprecated in HTML 5 should not be used
---
api/src/main/java/javax/jdo/datastore/package.html | 2 +-
api/src/main/java/javax/jdo/identity/package.html | 2 +-
api/src/main/java/javax/jdo/listener/package.html | 2 +-
api/src/main/java/javax/jdo/metadata/package.html | 2 +-
api/src/main/java/javax/jdo/package.html | 2 +-
api/src/main/java/javax/jdo/spi/package.html | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/api/src/main/java/javax/jdo/datastore/package.html b/api/src/main/java/javax/jdo/datastore/package.html
index f55f71ca..f68d875e 100644
--- a/api/src/main/java/javax/jdo/datastore/package.html
+++ b/api/src/main/java/javax/jdo/datastore/package.html
@@ -22,7 +22,7 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
+<body>
This package contains the JDO specification datastore interfaces.
</body>
</html>
diff --git a/api/src/main/java/javax/jdo/identity/package.html b/api/src/main/java/javax/jdo/identity/package.html
index 035f3b40..aebf5917 100644
--- a/api/src/main/java/javax/jdo/identity/package.html
+++ b/api/src/main/java/javax/jdo/identity/package.html
@@ -22,7 +22,7 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
+<body>
This package contains the JDO specification identity interfaces and classes.
</body>
</html>
diff --git a/api/src/main/java/javax/jdo/listener/package.html b/api/src/main/java/javax/jdo/listener/package.html
index a01bc754..8f0cf853 100644
--- a/api/src/main/java/javax/jdo/listener/package.html
+++ b/api/src/main/java/javax/jdo/listener/package.html
@@ -22,7 +22,7 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
+<body>
This package contains the JDO specification listener interfaces and classes.
<P>There are two kinds of interfaces defined to allow an application to
manage life cycle changes to persistent objects.
diff --git a/api/src/main/java/javax/jdo/metadata/package.html b/api/src/main/java/javax/jdo/metadata/package.html
index f1b702ca..7523f68d 100644
--- a/api/src/main/java/javax/jdo/metadata/package.html
+++ b/api/src/main/java/javax/jdo/metadata/package.html
@@ -22,7 +22,7 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
+<body>
This package contains classes representing the different components of the JDO Metadata.
It mirrors the structure of the XML schema.
</body>
diff --git a/api/src/main/java/javax/jdo/package.html b/api/src/main/java/javax/jdo/package.html
index a2e89dda..f2266724 100644
--- a/api/src/main/java/javax/jdo/package.html
+++ b/api/src/main/java/javax/jdo/package.html
@@ -22,7 +22,7 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
+<body>
This package contains the JDO specification interfaces and classes.
<P>There are two major objectives of the JDO architecture:
first, to provide application programmers a transparent,
diff --git a/api/src/main/java/javax/jdo/spi/package.html b/api/src/main/java/javax/jdo/spi/package.html
index c8c4b371..039d09ae 100644
--- a/api/src/main/java/javax/jdo/spi/package.html
+++ b/api/src/main/java/javax/jdo/spi/package.html
@@ -22,7 +22,7 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
+<body>
<P>This package contains the interfaces and classes used by JDO implementations.
<P>JDO defines interfaces and classes to be used by application programmers
when using classes whose instances are to be stored in persistent storage