You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/01/13 22:45:00 UTC
[jira] [Commented] (IMPALA-6894) Use an internal representation of
query states in ClientRequestState
[ https://issues.apache.org/jira/browse/IMPALA-6894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014710#comment-17014710 ]
ASF subversion and git services commented on IMPALA-6894:
---------------------------------------------------------
Commit a36e2c9c5eb313f5fddb08a52382ca3237397706 in impala's branch refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a36e2c9 ]
IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState
Fixes a DCHECK in ClientRequestState::UpdateNonErrorExecState where the
ClientRequestState ExecState attempts to transition from the ERROR to
the FINISHED state. The DCHECK was added in IMPALA-6894 in order to
prevent any invalid state transition attempts.
The fix is to modify UpdateNonErrorExecState so that it skips any
attempt to transition from the ERROR to the FINISHED state, which is in
line with the behavior prior to IMPALA-6894.
Testing:
* Ran core tests, unable to reproduce the original issue locally
Change-Id: Ie47444ed67704d9469310727eeec2e9a66516e77
Reviewed-on: http://gerrit.cloudera.org:8080/14991
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Use an internal representation of query states in ClientRequestState
> --------------------------------------------------------------------
>
> Key: IMPALA-6894
> URL: https://issues.apache.org/jira/browse/IMPALA-6894
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Reporter: Bikramjeet Vig
> Assignee: Sahil Takiar
> Priority: Major
> Labels: query-lifecycle
> Fix For: Impala 3.4.0
>
>
> Having an internal representation of states will be useful as we can conveniently add/remove new states and develop logic around those eg. [initialization, analysis complete, planning complete/queued, running] (set the stage for IMPALA-2568 and its sub-tasks), [cancelled, exception etc] (IMPALA-1262).
> We can easily convert it to client (HS2 and Beeswax) specific states and ensure there are no client visible changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org