You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2019/06/22 13:11:35 UTC
Review Request 70929: Move Function and Macro related DDL operations
into the DDL framework
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70929/
-----------------------------------------------------------
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-21914
https://issues.apache.org/jira/browse/HIVE-21914
Repository: hive-git
Description
-------
Some Function and Macro related operations are handled by FunctionTask, and FunctionWork while they belong to the DDL framework.
Diffs
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java 136fe2a3b3
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/CreateFunctionOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/CreateMacroDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/CreateMacroOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/DropFunctionOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/DropMacroOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/ReloadFunctionOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 2061cf4577
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionUtils.java 200e26c310
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java f4a46e62cf
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 7eeca5f90a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2ae1db57aa
ql/src/java/org/apache/hadoop/hive/ql/optimizer/QueryPlanPostProcessor.java 74a4be4535
ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 2cfcc6b611
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 88b6068941
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/CreateFunctionHandler.java 3a32885d1d
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/DropFunctionHandler.java fee2bb5dbf
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java 92c00ca027
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java f34c02c77e
ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java d3415a5799
ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 2b0c683bc2
ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java cacbe62183
ql/src/java/org/apache/hadoop/hive/ql/plan/ReloadFunctionDesc.java ac1fba210e
ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 2189ad6bee
ql/src/test/org/apache/hadoop/hive/ql/plan/TestCreateMacroDesc.java 48906f70dd
ql/src/test/org/apache/hadoop/hive/ql/plan/TestDropMacroDesc.java 2ee27dc89b
ql/src/test/queries/clientpositive/create_func1.q eef07f64e5
ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 55e66f8ab8
ql/src/test/results/clientnegative/create_function_nonudf_class.q.out 6d5427ef59
ql/src/test/results/clientnegative/create_unknown_genericudf.q.out ad1371d6a5
ql/src/test/results/clientnegative/create_unknown_udf_udaf.q.out bfb72b4415
ql/src/test/results/clientnegative/ivyDownload.q.out e1fe8233cb
ql/src/test/results/clientnegative/udf_function_does_not_implement_udf.q.out ab42da766a
ql/src/test/results/clientnegative/udf_local_resource.q.out 62664c9c9a
ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out 4751761a8c
ql/src/test/results/clientpositive/create_func1.q.out d4afc83144
ql/src/test/results/clientpositive/create_genericudaf.q.out ca877bf90d
ql/src/test/results/clientpositive/create_genericudf.q.out cfe14f5c4a
ql/src/test/results/clientpositive/create_udaf.q.out 8e20b30651
ql/src/test/results/clientpositive/drop_udf.q.out 27dd986f21
ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 6925f58af1
ql/src/test/results/clientpositive/tez/explainuser_3.q.out 26eae7e8d0
ql/src/test/results/clientpositive/udf_compare_java_string.q.out 75d01249d7
ql/src/test/results/clientpositive/udf_logic_java_boolean.q.out 0d63db7f55
ql/src/test/results/clientpositive/udf_testlength.q.out 23a25d05be
ql/src/test/results/clientpositive/udf_testlength2.q.out 1a67685bf5
Diff: https://reviews.apache.org/r/70929/diff/1/
Testing
-------
All the tests are still running plus added some new q tests.
Thanks,
Miklos Gergely
Re: Review Request 70929: Move Function and Macro related DDL
operations into the DDL framework
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70929/
-----------------------------------------------------------
(Updated June 24, 2019, 8:41 a.m.)
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-21914
https://issues.apache.org/jira/browse/HIVE-21914
Repository: hive-git
Description
-------
Some Function and Macro related operations are handled by FunctionTask, and FunctionWork while they belong to the DDL framework.
Diffs (updated)
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java 136fe2a3b3
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/CreateFunctionOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/CreateMacroDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/CreateMacroOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/DropFunctionOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/DropMacroOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/ReloadFunctionsOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 2061cf4577
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionUtils.java 200e26c310
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java f4a46e62cf
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 7eeca5f90a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2ae1db57aa
ql/src/java/org/apache/hadoop/hive/ql/optimizer/QueryPlanPostProcessor.java 74a4be4535
ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 2cfcc6b611
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g e0230055ef
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 88b6068941
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 51a6b2a918
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/CreateFunctionHandler.java 3a32885d1d
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/DropFunctionHandler.java fee2bb5dbf
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java 92c00ca027
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java f34c02c77e
ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java d3415a5799
ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 2b0c683bc2
ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java cacbe62183
ql/src/java/org/apache/hadoop/hive/ql/plan/ReloadFunctionDesc.java ac1fba210e
ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 2189ad6bee
ql/src/test/org/apache/hadoop/hive/ql/plan/TestCreateMacroDesc.java 48906f70dd
ql/src/test/org/apache/hadoop/hive/ql/plan/TestDropMacroDesc.java 2ee27dc89b
ql/src/test/queries/clientpositive/create_func1.q eef07f64e5
ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 55e66f8ab8
ql/src/test/results/clientnegative/create_function_nonudf_class.q.out 6d5427ef59
ql/src/test/results/clientnegative/create_unknown_genericudf.q.out ad1371d6a5
ql/src/test/results/clientnegative/create_unknown_udf_udaf.q.out bfb72b4415
ql/src/test/results/clientnegative/ivyDownload.q.out e1fe8233cb
ql/src/test/results/clientnegative/udf_function_does_not_implement_udf.q.out ab42da766a
ql/src/test/results/clientnegative/udf_local_resource.q.out 62664c9c9a
ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out 4751761a8c
ql/src/test/results/clientpositive/create_func1.q.out d4afc83144
ql/src/test/results/clientpositive/create_genericudaf.q.out ca877bf90d
ql/src/test/results/clientpositive/create_genericudf.q.out cfe14f5c4a
ql/src/test/results/clientpositive/create_udaf.q.out 8e20b30651
ql/src/test/results/clientpositive/drop_udf.q.out 27dd986f21
ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 6925f58af1
ql/src/test/results/clientpositive/tez/explainuser_3.q.out 26eae7e8d0
ql/src/test/results/clientpositive/udf_compare_java_string.q.out 75d01249d7
ql/src/test/results/clientpositive/udf_logic_java_boolean.q.out 0d63db7f55
ql/src/test/results/clientpositive/udf_testlength.q.out 23a25d05be
ql/src/test/results/clientpositive/udf_testlength2.q.out 1a67685bf5
Diff: https://reviews.apache.org/r/70929/diff/2/
Changes: https://reviews.apache.org/r/70929/diff/1-2/
Testing
-------
All the tests are still running plus added some new q tests.
Thanks,
Miklos Gergely