[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5169: Table level timeout implementation

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5169: Table level timeout implementation
URL: https://github.com/apache/incubator-pinot/pull/5169#discussion_r396728226
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
 ##########
 @@ -354,9 +359,12 @@ public synchronized void buildRouting(String tableNameWithType) {
       }
     }
 
+    QueryConfig queryConfig = tableConfig.getQueryConfig();
+    Long timeoutMs = queryConfig != null ? queryConfig.getTimeoutMs() : null;
 
 Review comment:
   For json ser-de reason, it is risky to put `-1` for `null` value (serialize & deserialize will break). I'll just use `null` in both places then

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org