You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/01/07 09:11:20 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #13968: fix: gauge detail value animation broken by some previous commit.
100pah opened a new pull request #13968:
URL: https://github.com/apache/incubator-echarts/pull/13968
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
1. Enable gauge detail value animation again. (Broken by some previous commit)
2. Some restrict and clarify of the parameters of method `getFormattedLabel`:
Before:
```js
extendParams?: Partial<CallbackDataParams>
```
After:
```js
extendParams?: {
interpolatedValue: InterpolatableValue
}
```
Because:
1. this feature is only used in value animation case.
2. `CallbackDataParam` is only about the internal logic in one of the implementation of the interface `getFormattedLabel`.
The parameter of `getFormattedLabel` should not depends on some certain implementation.
There is other implementation of it, which need the parameter to have clear meaning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13968: fix: gauge detail value animation broken by some previous commit.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13968:
URL: https://github.com/apache/incubator-echarts/pull/13968#issuecomment-755987061
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13968: fix: gauge detail value animation broken by some previous commit.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13968:
URL: https://github.com/apache/incubator-echarts/pull/13968#issuecomment-756095657
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #13968: fix: gauge detail value animation broken by some previous commit.
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #13968:
URL: https://github.com/apache/incubator-echarts/pull/13968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org