You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/08/31 20:50:17 UTC
Review Request 37956: Only process instances if there's been a change.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37956/
-----------------------------------------------------------
Review request for Aurora and David McLaughlin.
Bugs: AURORA-1345
https://issues.apache.org/jira/browse/AURORA-1345
Repository: aurora
Description
-------
The `true` parameter to `scope.$watch` tells Angular to only execute the supplied function if the watched data has changed. Given our 15s polling interval is likely less than time it takes for any progress to be made on an update, this removes the majority of (no-op) DOM operations.
Diffs
-----
src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
Diff: https://reviews.apache.org/r/37956/diff/
Testing
-------
Left tab open continually polling a job with ~3000 instances, confirmed that memory usage did not grow beyond ~200MB.
Thanks,
Joshua Cohen
Re: Review Request 37956: Only process instances if there's been a
change.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37956/#review97125
-----------------------------------------------------------
Master (04b6858) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 31, 2015, 6:50 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37956/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 6:50 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Bugs: AURORA-1345
> https://issues.apache.org/jira/browse/AURORA-1345
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The `true` parameter to `scope.$watch` tells Angular to only execute the supplied function if the watched data has changed. Given our 15s polling interval is likely less than time it takes for any progress to be made on an update, this removes the majority of (no-op) DOM operations.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
>
> Diff: https://reviews.apache.org/r/37956/diff/
>
>
> Testing
> -------
>
> Left tab open continually polling a job with ~3000 instances, confirmed that memory usage did not grow beyond ~200MB.
>
>
> Thanks,
>
> Joshua Cohen
>
>