You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/04 23:43:51 UTC

[GitHub] [spark] maropu commented on a change in pull request #31740: [SPARK_34623][SQL] Remove duplicate window expressions from the Window node

maropu commented on a change in pull request #31740:
URL: https://github.com/apache/spark/pull/31740#discussion_r587915430



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -90,6 +90,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
         // Constant folding and strength reduction
         OptimizeRepartition,
         TransposeWindow,
+        DeduplicateWindowExpressions,

Review comment:
       `DeduplicateWindowExpressions` -> `RemoveDeduplicateWindowExprs`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org