[GitHub] [rocketmq] zongtanghu commented on a change in pull request #1126: [ISSUE #1125] Fix trace problem when consumer and producer running in the same process

[GitBox <gi...@apache.org>]

zongtanghu commented on a change in pull request #1126: [ISSUE #1125] Fix trace problem when consumer and producer running in the same process
URL: https://github.com/apache/rocketmq/pull/1126#discussion_r270783918
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java
 ##########
 @@ -71,7 +71,7 @@
     private volatile ThreadLocalIndex sendWhichQueue = new ThreadLocalIndex();
     private String dispatcherId = UUID.randomUUID().toString();
     private String traceTopicName;
-    private AtomicBoolean isStarted = new AtomicBoolean(false);
 
 Review comment:
   Here,you can look at another pr before,the pr's link is:https://github.com/apache/rocketmq/pull/694.If you make the isStarted variable to non-static,it will result in some issues in sending trace msgs to different clusters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services