You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2011/09/27 23:36:44 UTC

[VOTE] Release Apache Tomcat 7.0.22

The proposed Apache Tomcat 7.0.22 release is now available for voting.

It can be obtained from:
http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/

The proposed 7.0.21 release is:

[ ] Broken - do not release
[ ] Beta   - go ahead and release as 7.0.22 Beta
[ ] Stable - go ahead and release as 7.0.22 Stable

I dropped alpha as if it is that unstable, I'll re-roll the release.

Cheers,

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Mark Thomas <ma...@apache.org>.
On 27/09/2011 17:36, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.22 release is now available for voting.
> 
> It can be obtained from:
> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
> 
> The proposed 7.0.21 release is:
> 
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 7.0.22 Beta
> [X] Stable - go ahead and release as 7.0.22 Stable

EL TCK passes
JSP TCK passes with HTTP (BIO, NIO, APR)
Servlet TCK passes with HTTP, HTTP+mod_proxy_http, AJP+mod_jk,
AJP+mod_proxy_ajp with all 3 variants (BIO, NIO, APR)

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[RESULT] [VOTE] Release Apache Tomcat 7.0.22

Posted by Mark Thomas <ma...@apache.org>.
With 5 +1's (4 binding) the vote passes. I'll copy the binaries to mino
now and announce the release once the mirrors have sync'd.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Mark Thomas <ma...@apache.org>.
On 28/09/2011 10:24, Rainer Jung wrote:
> On 27.09.2011 23:36, Mark Thomas wrote:
>> The proposed Apache Tomcat 7.0.22 release is now available for voting.
>>
>> It can be obtained from:
>> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
>>
>> The proposed 7.0.21 release is:
>>
>> [ ] Broken - do not release
>> [ ] Beta   - go ahead and release as 7.0.22 Beta
>> [X] Stable - go ahead and release as 7.0.22 Stable
> 
> It would be nice though to know your final analysis of BZ 51881 (Server
> incorrectly parses incoming HTTP requests and loses them) before
> publising the release.

I'm getting closer. It is, as the OP suggested, a problem with handling
async closes of comet connections (where a request on thread A triggers
the close of the comet request on thread B). I haven't quite got to the
bottom of it yet but so far the indications are this isn't something
that we'll need to do an immediate 7.0.23 for.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Rainer Jung <ra...@kippdata.de>.
On 27.09.2011 23:36, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.22 release is now available for voting.
> 
> It can be obtained from:
> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
> 
> The proposed 7.0.21 release is:
> 
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 7.0.22 Beta
> [X] Stable - go ahead and release as 7.0.22 Stable

It would be nice though to know your final analysis of BZ 51881 (Server
incorrectly parses incoming HTTP requests and loses them) before
publising the release.

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
  Except for the following minor points (no regression):
  - The files we copy before building, e.g.
    catalina.properties and jdbc-pool.xml are of course
    not in svn for the cp target location, but they are there
    in the src bundles.
  - line ends of modules/jdbc-pool/resources/MANIFEST.MF differ
    between svn and gz although eol-style is set correctly.
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc errors
- Unit tests run OK for BIO, NIO and APR
  Not a single test failure
- JMX MBean-Comparison small expected differences:
  - keepAliveTimeout changed from "-1" to "20000"
    in HTTP MBeans for ThreadPool, ProtocolHandler
    and Connector (at least for BIO)
  - New attribute "usePolling" in ThreadPool MBean
  - logging MBean changes due to Digester logger rename

Build and tests were done using Java 1.6.0_26, OS was Solaris 10 Sparc,
tcnative was 1.1.22 based on APR 1.4.5 and OpenSSL 0.9.8r.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/9/28 Mark Thomas <ma...@apache.org>:
> The proposed Apache Tomcat 7.0.22 release is now available for voting.
>
> It can be obtained from:
> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
>
> The proposed 7.0.21 release is:
>
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 7.0.22 Beta
> [x] Stable - go ahead and release as 7.0.22 Stable
>


While testing I have encountered two issues, but I do not see them as
showstoppers. Added to Bugzilla as

https://issues.apache.org/bugzilla/show_bug.cgi?id=51910
https://issues.apache.org/bugzilla/show_bug.cgi?id=51912

Except the issue described by BZ 51912,
all the rest of testsuite did run for me successfully with all three
of BIO, NIO, APR connectors on WinXP, JDK 6u26.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Mladen Turk <mt...@apache.org>.
On 09/27/2011 11:36 PM, Mark Thomas wrote:
>
> The proposed 7.0.21 release is:
>
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 7.0.22 Beta
> [x] Stable - go ahead and release as 7.0.22 Stable
>

Do an usual set of tests on win32/win64 and linux

Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Mark Thomas <ma...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 29/09/2011 12:17, Christopher Schultz wrote:
> Mark,
> 
> On 9/29/2011 8:09 AM, Mark Thomas wrote:
>> On 28/09/2011 14:43, Christopher Schultz wrote:
>>> Mark,
>> 
>>> On 9/27/2011 5:36 PM, Mark Thomas wrote:
>>>> The proposed Apache Tomcat 7.0.22 release is now available
>>>> for voting.
>>>> 
>>>> It can be obtained from: 
>>>> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/ The svn
>>>> tag is: 
>>>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
>>>>
>>>>
>>>>
>>
>>>> 
The proposed 7.0.21 release is:
>>>> 
>>>> [ ] Broken - do not release [ ] Beta   - go ahead and release
>>>> as 7.0.22 Beta [X] Stable - go ahead and release as 7.0.22
>>>> Stable
>> 
>>> + MD5 sums match. - GPG verifies with a key that Mark appears
>>> to use for nothing else, no key signers :(
>> 
>> Huh?
>> 
>> $ gpg --verify catalina-jmx-remote.jar.asc
>> catalina-jmx-remote.jar gpg: Signature made Tue 27 Sep 16:47:07
>> 2011 EDT using RSA key ID 2F6059E7 gpg: Good signature from "Mark
>> E D Thomas <ma...@apache.org>"
> 
> Running --verify wasn't the problem (it verifies). I was talking
> about other people signing your GPG key.

The --verify was to show which key I used to sign the binaries.

> It was also distinct from the other key I had for you (0x33C60243)
> so I wasn't sure why there were two. Some ASF folks have two, one
> clearly marked (CODE SIGNING KEY)... it just appears you haven't
> done the same.

See http://people.apache.org/~markt/TRANSITION.asc

I use one key for everything.

> Weird... I got no signers when I first obtained your key. Updating
> the key shows 28 signatures so maybe I was on crack at the time. Or
> now.
> 
>> http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x10C01C5A2F6059E7
>>
>>
>> 
That key is very firmly in the ASF web of trust.
>> 
>> It is also in the KEYS file.
> 
> Yup, all is well.

np

Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOhKNWAAoJEBDAHFovYFnnRRMP/0XhOEToihEn0emgnhhY6yon
FbnaT9E2cL8t/xcArKb36kWoftjtZOemk2bpBK6+dEM9bzserwLHv+pSF+okyxva
InZ7owFvjcsLabNEWyYOGNjMPLPB3tD5otarF0D9EKA0zr09JJWUGdU0twUvswcj
uO6fC3cmWd32mPteU6ZaDd1g6wyrXEyIa0o2F+RR0DugEQ2obCaP0pGdax0v54lV
BP2EzLtp2TYyj467x9mM8Sae7FJ5iEEcxwwbBxoA5F7DuqG2ZOHqgtxg/nvKGXZk
Jy8nMxt+YuoGbMNzH+tjdmYeDdpcm2oDzOhKDr4aR1ViImKTlv2jMY1XiE1L8THX
1RLSe6WXlEDhm7z1ExX1Fm968D6B1gPJ6OyWoAZZFPc5jiy3gIxIaouID8ZR7yLY
juY0GcSH+FsgGOnKmL5kWhWnF+18PR/XwEe6vVcmTysuEr1xWUsVoqdMky4ho2Em
ldiM8ekSsb8Nk8eaFVS2UBCHVGdu/31zoxQlAHXIHiXPhx2TtttQ5iQrzzTafD24
kGpLacVkdczLsT5n7FUpY5CIdYf6LeNQZM/HSkW+Bp1vfhdA471ovaNxghwOPU4B
RlaPctkuXFLCcYOor7AYjymlgTxTWK68lzj24Q1LYkK68meM55lVeZ1N5ERZ+pkD
GEhJqw/FLEGMgY/TyDSY
=mb+O
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,

On 9/29/2011 8:09 AM, Mark Thomas wrote:
> On 28/09/2011 14:43, Christopher Schultz wrote:
>> Mark,
> 
>> On 9/27/2011 5:36 PM, Mark Thomas wrote:
>>> The proposed Apache Tomcat 7.0.22 release is now available for
>>> voting.
>>>
>>> It can be obtained from: 
>>> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/ The svn tag
>>> is: 
>>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
>>>
>>>
>>>
> The proposed 7.0.21 release is:
>>>
>>> [ ] Broken - do not release [ ] Beta   - go ahead and release as
>>> 7.0.22 Beta [X] Stable - go ahead and release as 7.0.22 Stable
> 
>> + MD5 sums match. - GPG verifies with a key that Mark appears to
>> use for nothing else, no key signers :(
> 
> Huh?
> 
> $ gpg --verify catalina-jmx-remote.jar.asc catalina-jmx-remote.jar
> gpg: Signature made Tue 27 Sep 16:47:07 2011 EDT using RSA key ID 2F6059E7
> gpg: Good signature from "Mark E D Thomas <ma...@apache.org>"

Running --verify wasn't the problem (it verifies). I was talking about
other people signing your GPG key.

It was also distinct from the other key I had for you (0x33C60243) so I
wasn't sure why there were two. Some ASF folks have two, one clearly
marked (CODE SIGNING KEY)... it just appears you haven't done the same.

Weird... I got no signers when I first obtained your key. Updating the
key shows 28 signatures so maybe I was on crack at the time. Or now.

> http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x10C01C5A2F6059E7
> 
> That key is very firmly in the ASF web of trust.
> 
> It is also in the KEYS file.

Yup, all is well.

-chris


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Mark Thomas <ma...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28/09/2011 14:43, Christopher Schultz wrote:
> Mark,
> 
> On 9/27/2011 5:36 PM, Mark Thomas wrote:
>> The proposed Apache Tomcat 7.0.22 release is now available for
>> voting.
>> 
>> It can be obtained from: 
>> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/ The svn tag
>> is: 
>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
>>
>>
>> 
The proposed 7.0.21 release is:
>> 
>> [ ] Broken - do not release [ ] Beta   - go ahead and release as
>> 7.0.22 Beta [X] Stable - go ahead and release as 7.0.22 Stable
> 
> + MD5 sums match. - GPG verifies with a key that Mark appears to
> use for nothing else, no key signers :(

Huh?

$ gpg --verify catalina-jmx-remote.jar.asc catalina-jmx-remote.jar
gpg: Signature made Tue 27 Sep 16:47:07 2011 EDT using RSA key ID 2F6059E7
gpg: Good signature from "Mark E D Thomas <ma...@apache.org>"

http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x10C01C5A2F6059E7

That key is very firmly in the ASF web of trust.

It is also in the KEYS file.

Mark

> + Source builds properly + All unit tests pass + Javadoc builds
> with no complaints + Works with casual testing of my own webapps
> 
> -chris
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOhGAPAAoJEBDAHFovYFnn6TsP/1ywfc98/BCzJVeF5WCyWCwX
V1gBHlIFapqUtJH1/kus5vKM6SJbnOaeex5GnUbew886vBrT0JorSF5U4G7zzYCY
HCflusjYcPHB63AhsAB8ZhLIq5eyM7e2Tsv+M0dibiQHJHTK9qogLxz//znWOmiW
b5WAP1UvEDhqvi2asJNX38IClDtPyjEFGT7ZMIj+Pj7gAQSyO8+f0grZno4rNA+a
e3vxj2DnnqXOe6k18+t8iOapp9ds1FLu8yMwtwh4DKEKtion3hzceqauJZ9VKHu/
6Pz+gVA5XAmQQ3gbFTY3VUXHu8E6GZOhtjbfCf/8ddo2aIcdDbo4tPERrXJoXeZl
vwg90pwqarqo++Qa7dqJhqymphxW+6sFXP6KHw7L7/G7cORey3oa+3AkNwtBE8Ip
CWoEsSuMbJtA/Yz0Qv8AcVcukommACRdDzsJfnnDPCv3C1wLoar9jxDF9lhrq5gi
mwZKt6w3UdtsAMSBcsQnvkDRIxkWdFqcKAg0Ysz3re2lyl9laaUFH9X0/Lsi1GVu
yq19Gk/eQtXnWcXh56sUaJymou6MXrTqTBniafwJZ6rrYq7aHFQJpKHF2aehzHlg
a00PkblnvbhOGaIwytujC593WuQFiTamuxG1iCS2H+nW2ii7Di48oHShnrPPEOUf
JdlkG0Y451HoATV6sX9m
=d6hC
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.22

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,

On 9/27/2011 5:36 PM, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.22 release is now available for voting.
> 
> It can be obtained from:
> http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/
> 
> The proposed 7.0.21 release is:
> 
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 7.0.22 Beta
> [X] Stable - go ahead and release as 7.0.22 Stable

+ MD5 sums match.
- GPG verifies with a key that Mark appears to use for nothing else,
  no key signers :(
+ Source builds properly
+ All unit tests pass
+ Javadoc builds with no complaints
+ Works with casual testing of my own webapps

-chris