[jira] Commented: (HDFS-956) Improper synchronization in some FSNamesystem methods

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831218#action_12831218 ] 

Todd Lipcon commented on HDFS-956:
----------------------------------

Quick search through FSNamesystem shows:
- concat checks safemode before entering synchronization block
- setQuota isn't synchronized at all (it calls dir.setQuota with no synchronization either)
- renewLease isn't synchronized (not certain for sure if this has to be - it seems like it ought to be so that the leases serialized in an fsimage are consistent)
- computeDatanodeWork - this one is a bit tricky as well. Is blockManager.updateState() safe to call in safeMode?


> Improper synchronization in some FSNamesystem methods
> -----------------------------------------------------
>
>                 Key: HDFS-956
>                 URL: https://issues.apache.org/jira/browse/HDFS-956
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>
> There are some methods in FSNamesystem that check isInSafeMode while not synchronized, and then proceed to perform operations. Thus the actual operations can occur after the NN has entered safemode, which is no good.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.