[GitHub] [helix] narendly commented on a change in pull request #1136: Add option to return pref lists based results

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #1136:
URL: https://github.com/apache/helix/pull/1136#discussion_r449257772



##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -173,10 +174,43 @@ public static String serializeByComma(List<String> objects) {
    * @param resourceConfigs
    * @return
    */
-  public static Map<String, ResourceAssignment> getIdealAssignmentForWagedFullAuto(
+  public static Map<String, ResourceAssignment> getTargetAssignmentForWagedFullAuto(

Review comment:
       Shouldn't we leave this unchanged since this is a public method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org