[GitHub] [kafka] sayantanu-dey commented on a change in pull request #11703: KAFKA-13588: consolidate `changelogFor` methods to simplify the generation of internal topic names

[GitBox <gi...@apache.org>]

sayantanu-dey commented on a change in pull request #11703:
URL: https://github.com/apache/kafka/pull/11703#discussion_r790421944



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##########
@@ -171,42 +169,24 @@ private void registerMetrics() {
     @Deprecated
     private void initStoreSerde(final ProcessorContext context) {
         final String storeName = name();
-        final String changelogTopic = ProcessorContextUtils.changelogFor(context, storeName);
-        final String prefix = getPrefix(context.appConfigs(), context.applicationId());
+        final String changelogTopic = ProcessorContextUtils.changelogFor(context, storeName, Boolean.FALSE);

Review comment:
       What I understood going through the code is that in MeteredXYZStore classes first, we check if the returned value is null then we create a new topic, and in classes, like WindowCacheStore and InMemoryTimeOrderedKeyValueBuffer we always need to create a new topic.
   Hence I introduced the third param which when false goes through the whole procedure of checking null and creating a new topic, and in case the param is set to True it just creates a new topic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org