You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2018/05/03 21:25:12 UTC

[incubator-pulsar] 02/02: Exclude grpc dependencies in binary distribution (#1724)

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git

commit ea1230aef81d68ac98edeee188439b350d4cadc0
Author: Sijie Guo <gu...@gmail.com>
AuthorDate: Thu May 3 14:04:39 2018 -0700

    Exclude grpc dependencies in binary distribution (#1724)
    
    *Motivation*
    
    Gprc is used by functions as control plane. The dependencies were shaded in `pulsar-functions-runtime`. However the assembly plugin still
    includes those dependencies in the binary distribution. It causes the conflicts between protobuf versions.
    
    *Solution*
    
    Exclude grpc dependencies in binary distribution.
---
 all/src/assemble/bin.xml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/all/src/assemble/bin.xml b/all/src/assemble/bin.xml
index e74b684..3c58be7 100644
--- a/all/src/assemble/bin.xml
+++ b/all/src/assemble/bin.xml
@@ -111,6 +111,9 @@
         <!-- Already included in pulsar-zookeeper instrumented jar -->
         <exclude>org.apache.zookeeper:zookeeper</exclude>
 
+        <!-- Already shaded in runtime-shaded jar -->
+        <exclude>io.grpc:*</exclude>
+
         <!-- Explicitely remove JUnit which is getting pulled in even
              though it's set to the scope 'test' -->
         <exclude>junit:junit</exclude>

-- 
To stop receiving notification emails like this one, please contact
mmerli@apache.org.