You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "mmodzelewski (via GitHub)" <gi...@apache.org> on 2026/03/13 13:16:00 UTC
[PR] refactor(java): replace JUnit assertions with AssertJ across all tests [iggy]
mmodzelewski opened a new pull request, #2929:
URL: https://github.com/apache/iggy/pull/2929
Six test files still used JUnit assertions (assertEquals,
assertThrows, assertNotNull, etc.) instead of the project
standard AssertJ fluent API. This inconsistency made tests
harder to read and diverged from the convention used by
the rest of the test suite.
Migrated all JUnit assertion calls to AssertJ equivalents
and added an AssertJ note to the Contributing section in
README.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(java): replace JUnit assertions with AssertJ across all tests [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2929:
URL: https://github.com/apache/iggy/pull/2929#issuecomment-4055882040
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2929?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 70.26%. Comparing base ([`c90b5f8`](https://app.codecov.io/gh/apache/iggy/commit/c90b5f8bf8608d66f224eec128c4495fdcbeb848?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fc02a88`](https://app.codecov.io/gh/apache/iggy/commit/fc02a88f35119a292895538e71f69729f0deddc5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2929 +/- ##
============================================
- Coverage 70.28% 70.26% -0.03%
Complexity 862 862
============================================
Files 1028 1028
Lines 85279 85279
Branches 62655 62655
============================================
- Hits 59939 59921 -18
- Misses 22825 22841 +16
- Partials 2515 2517 +2
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2929/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/iggy/pull/2929/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.87% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 6 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2929/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(java): replace JUnit assertions with AssertJ across all tests [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #2929:
URL: https://github.com/apache/iggy/pull/2929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org