You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/04/20 01:35:14 UTC
Review Request 46418: Refactored the `os::access` function between
POSIX and Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46418/
-----------------------------------------------------------
Review request for mesos, Daniel Pravat, Alex Clemmer, and Joris Van Remoortere.
Bugs: MESOS-5237
https://issues.apache.org/jira/browse/MESOS-5237
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp a81086860a17bd1912e55051dd7bb98a20772b51
3rdparty/libprocess/3rdparty/stout/include/stout/os/access.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f1584d0786ee0236a0e703d4aa9532e138ad49f0
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 37ef33257830e32875500537df7af38757c6efac
Diff: https://reviews.apache.org/r/46418/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 46418: Refactored the `os::access` function
between POSIX and Windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46418/#review129693
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46418]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 19, 2016, 11:35 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46418/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 11:35 p.m.)
>
>
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joris Van Remoortere.
>
>
> Bugs: MESOS-5237
> https://issues.apache.org/jira/browse/MESOS-5237
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp a81086860a17bd1912e55051dd7bb98a20772b51
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/access.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f1584d0786ee0236a0e703d4aa9532e138ad49f0
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 37ef33257830e32875500537df7af38757c6efac
>
> Diff: https://reviews.apache.org/r/46418/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>