[GitHub] [ozone] Xushaohong commented on a diff in pull request #3615: HDDS-7023. Add CLI for reseting the expired deleted block txn

[GitBox <gi...@apache.org>]

Xushaohong commented on code in PR #3615:
URL: https://github.com/apache/ozone/pull/3615#discussion_r934351998


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManagerImpl.java:
##########
@@ -209,6 +209,23 @@ public void increaseRetryCountOfTransactionInDB(
     }
   }
 
+  @Override
+  public int resetRetryCountOfTransactionInDB(ArrayList<Long> txIDs)
+      throws IOException {
+    for (long txId: txIDs) {
+      DeletedBlocksTransaction transaction = deletedTable.get(txId);

Review Comment:
   > We need to handle the case where txn is not present in db.
   
   This is already handled in `DeletedBlockLogImpl`,  only the filtered txns will be processed.
   
   
   > Also what if retry count of this transaction is > 0 already?
   
   In this case, we do nothing for them now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org