You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/07 06:32:07 UTC
[GitHub] [apisix-ingress-controller] navendu-pottekkat opened a new pull request, #1443: docs: update "Development" guide
navendu-pottekkat opened a new pull request, #1443:
URL: https://github.com/apache/apisix-ingress-controller/pull/1443
Signed-off-by: Navendu Pottekkat <na...@apache.org>
Updates the "Development" guide and makes it consistent with APISIX guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat commented on a diff in pull request #1443: docs: update "Development" guide
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on code in PR #1443:
URL: https://github.com/apache/apisix-ingress-controller/pull/1443#discussion_r1015114207
##########
docs/en/latest/contribute.md:
##########
@@ -21,92 +27,103 @@ title: Developing for Apache APISIX Ingress Controller
#
-->
-This document explains how to get started with developing for Apache APISIX Ingress controller.
+This document walks through how you can set up your development environment to contribute to APISIX Ingress controller.
## Prerequisites
-* Install [Go 1.19](https://golang.org/dl/) or later, and we use go module to manage the go package dependencies.
-* Prepare an available Kubernetes cluster in your workstation, we recommend you to use [KIND](https://kind.sigs.k8s.io/).
-* Install Apache APISIX in Kubernetes by [Helm Chart](https://github.com/apache/apisix-helm-chart).
+Before you get started make sure you have:
+
+1. Installed [Go 1.13](https://golang.org/dl/) or later
Review Comment:
Of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat commented on pull request #1443: docs: update "Development" guide
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on PR #1443:
URL: https://github.com/apache/apisix-ingress-controller/pull/1443#issuecomment-1311321586
I have fixed the link check error in a different PR. All checks will pass here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat commented on pull request #1443: docs: update "Development" guide
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on PR #1443:
URL: https://github.com/apache/apisix-ingress-controller/pull/1443#issuecomment-1311248682
The lint error is from a different PR. We can merge this if there are no issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1443: docs: update "Development" guide
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1443:
URL: https://github.com/apache/apisix-ingress-controller/pull/1443#discussion_r1015085278
##########
docs/en/latest/contribute.md:
##########
@@ -21,92 +27,103 @@ title: Developing for Apache APISIX Ingress Controller
#
-->
-This document explains how to get started with developing for Apache APISIX Ingress controller.
+This document walks through how you can set up your development environment to contribute to APISIX Ingress controller.
## Prerequisites
-* Install [Go 1.19](https://golang.org/dl/) or later, and we use go module to manage the go package dependencies.
-* Prepare an available Kubernetes cluster in your workstation, we recommend you to use [KIND](https://kind.sigs.k8s.io/).
-* Install Apache APISIX in Kubernetes by [Helm Chart](https://github.com/apache/apisix-helm-chart).
+Before you get started make sure you have:
+
+1. Installed [Go 1.13](https://golang.org/dl/) or later
Review Comment:
we should use Go 1.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] juzhiyuan merged pull request #1443: docs: update "Development" guide
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #1443:
URL: https://github.com/apache/apisix-ingress-controller/pull/1443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org