[GitHub] [spark] mridulm commented on pull request #34158: [SPARK-36705][FOLLOW-UP] Support the case when user's classes need to register for Kryo serialization

[GitBox <gi...@apache.org>]

mridulm commented on pull request #34158:
URL: https://github.com/apache/spark/pull/34158#issuecomment-931737776


   Thanks for reviewing @srowen.
   The context is that [Utils.isPushBasedShuffleEnabled](https://github.com/apache/spark/blob/119ddd7e9526ed899f88a944babb74af693297f5/core/src/main/scala/org/apache/spark/util/Utils.scala#L2609) is invoked within the initialization path of driver and executor (as part of SparkEnv creation) as well as in other places (after SparkEnv.get is available).
   
   As part of `isPushBasedShuffleEnabled`, we need to check if the serializer supports relocation or not : which requires creation/initialization of the configured Serializer.
   With the existing version, this fails as there are multiple creation paths for `Serializer`.
   This PR should help address this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org