You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2018/10/16 15:31:37 UTC
[1/2] lucene-solr:master: SOLR-12876: upon failure report exception
message in ShardParamsTest.testGetShardsTolerantAsBool
Repository: lucene-solr
Updated Branches:
refs/heads/master 761f8aaf7 -> 95af8d6ac
SOLR-12876: upon failure report exception message in ShardParamsTest.testGetShardsTolerantAsBool
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/7fa19d26
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/7fa19d26
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/7fa19d26
Branch: refs/heads/master
Commit: 7fa19d2676afc8a9545d903239c942044d7b2765
Parents: 761f8aa
Author: Christine Poerschke <cp...@apache.org>
Authored: Tue Oct 16 10:52:11 2018 -0400
Committer: Christine Poerschke <cp...@apache.org>
Committed: Tue Oct 16 10:52:11 2018 -0400
----------------------------------------------------------------------
.../src/test/org/apache/solr/common/params/ShardParamsTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/7fa19d26/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
----------------------------------------------------------------------
diff --git a/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java b/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
index 5694972..b17f217 100644
--- a/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
+++ b/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
@@ -77,6 +77,6 @@ public class ShardParamsTest extends LuceneTestCase
// values that aren't "requireZkConnected" or boolean should throw an exception
params.set(ShardParams.SHARDS_TOLERANT, "bogusValue");
Exception exception = expectThrows(SolrException.class, () -> ShardParams.getShardsTolerantAsBool(params));
- assertTrue(exception.getMessage().startsWith("invalid boolean value: "));
+ assertTrue(exception.getMessage(), exception.getMessage().startsWith("invalid boolean value: "));
}
}
[2/2] lucene-solr:master: SOLR-12876: remove @BadApple from
ShardParamsTest.testGetShardsTolerantAsBool
Posted by cp...@apache.org.
SOLR-12876: remove @BadApple from ShardParamsTest.testGetShardsTolerantAsBool
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/95af8d6a
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/95af8d6a
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/95af8d6a
Branch: refs/heads/master
Commit: 95af8d6ac20a46f940dcb93c6183f32aa5181a2d
Parents: 7fa19d2
Author: Christine Poerschke <cp...@apache.org>
Authored: Tue Oct 16 10:52:51 2018 -0400
Committer: Christine Poerschke <cp...@apache.org>
Committed: Tue Oct 16 10:52:51 2018 -0400
----------------------------------------------------------------------
.../src/test/org/apache/solr/common/params/ShardParamsTest.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/95af8d6a/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
----------------------------------------------------------------------
diff --git a/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java b/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
index b17f217..b300a0f 100644
--- a/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
+++ b/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java
@@ -52,7 +52,6 @@ public class ShardParamsTest extends LuceneTestCase
public void testDistribSinglePass() { assertEquals(ShardParams.DISTRIB_SINGLE_PASS, "distrib.singlePass"); }
@Test
- @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Sep-2018
public void testGetShardsTolerantAsBool() {
ModifiableSolrParams params = new ModifiableSolrParams();
// shards.tolerant param is not set; default should be false