[jira] [Commented] (HBASE-17934) Backport HBASE-17779 "disable_table_replication returns misleading message and does not turn off replication" to branch-1.3

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160079#comment-16160079 ] 

Hadoop QA commented on HBASE-17934:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} | {color:red} HBASE-17934 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-17934 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12886279/17934-branch-1.3.patch |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8538/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Backport HBASE-17779 "disable_table_replication returns misleading message and does not turn off replication" to branch-1.3
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17934
>                 URL: https://issues.apache.org/jira/browse/HBASE-17934
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Janos Gub
>             Fix For: 1.3.2
>
>         Attachments: 17934-branch-1.3.patch, HBASE-17934.patch
>
>
> Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns families is not replicated.
> Because of this if you have a table where replication is partially enabled, calling disable_table_replication will not have any effect, but will report that replication for a given table is disabled.
> Workaround is enabling table replication before disabling.
> As a solution quoted from HBASE-17460:
> Admin#disableTableReplication() returns nothing and isTableRepEnabled() returns boolean. For master branch, we can let isTableRepEnabled() return enum (partially disabled, disabled, etc) This way, Admin#disableTableReplication() can return meaningful value to the user.
> This issue is to backport the fix to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)