You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/28 02:16:53 UTC
[GitHub] [skywalking] EvanLjp opened a new pull request #5571: inject span tags from correlation
EvanLjp opened a new pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] New feature provided
- Related issues
___
### New feature or improvement
- inject tags from correlation for stress testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 177 -724
Lines 22153 4161 -17992
Branches 2118 479 -1639
============================================
- Hits 11437 0 -11437
+ Misses 9797 4161 -5636
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [868 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 51.45% -0.18%
- Complexity 3322 3327 +5
============================================
Files 901 901
Lines 22153 22180 +27
Branches 2118 2113 -5
============================================
- Hits 11437 11413 -24
- Misses 9797 9839 +42
- Partials 919 928 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [47 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `11.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 40.50% -11.13%
+ Complexity 3322 2548 -774
=============================================
Files 901 897 -4
Lines 22153 22034 -119
Branches 2118 2111 -7
=============================================
- Hits 11437 8924 -2513
- Misses 9797 12443 +2646
+ Partials 919 667 -252
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.86%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.48% +0.86%
- Complexity 3322 3364 +42
============================================
Files 901 895 -6
Lines 22153 22075 -78
Branches 2118 2101 -17
============================================
+ Hits 11437 11587 +150
+ Misses 9797 9559 -238
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <8.33%> (-0.27%)` | `25.00 <1.00> (+2.00)` | :arrow_down: |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7b2a0b4dac7ba32ca380c945b4110f3c781dfbd3?el=desc) will **decrease** coverage by `0.97%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 53.12% 52.15% -0.98%
+ Complexity 3391 3369 -22
============================================
Files 880 1607 +727
Lines 21957 34158 +12201
Branches 2089 3721 +1632
============================================
+ Hits 11665 17815 +6150
- Misses 9361 15476 +6115
+ Partials 931 867 -64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `67.50% <20.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `59.21% <42.30%> (+46.00%)` | `6.00 <2.00> (+2.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.17% <66.66%> (+25.36%)` | `14.00 <1.00> (+1.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `70.58% <70.58%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `57.95% <75.00%> (+13.76%)` | `17.00 <0.00> (-1.00)` | :arrow_up: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `71.27% <92.85%> (+21.82%)` | `25.00 <1.00> (+2.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `5.55% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [1133 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [7b2a0b4...b5b592d](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `20.82%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 30.80% -20.83%
+ Complexity 3322 1985 -1337
=============================================
Files 901 878 -23
Lines 22153 21496 -657
Branches 2118 2050 -68
=============================================
- Hits 11437 6622 -4815
- Misses 9797 14390 +4593
+ Partials 919 484 -435
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [299 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.56% +0.94%
- Complexity 3322 3373 +51
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11609 +172
+ Misses 9797 9545 -252
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `50.27% <8.33%> (+0.81%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `30.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 21.60% -30.03%
+ Complexity 3322 1476 -1846
=============================================
Files 901 877 -24
Lines 22153 21212 -941
Branches 2118 1999 -119
=============================================
- Hits 11437 4583 -6854
- Misses 9797 16305 +6508
+ Partials 919 324 -595
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [414 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.56%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.19% +0.56%
- Complexity 3322 3362 +40
============================================
Files 901 901
Lines 22153 22193 +40
Branches 2118 2113 -5
============================================
+ Hits 11437 11583 +146
+ Misses 9797 9681 -116
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `55.55% <0.00%> (-22.23%)` | `2.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| ... and [26 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.86%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.49% +0.86%
- Complexity 3322 3366 +44
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11592 +155
+ Misses 9797 9563 -234
- Partials 919 928 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <8.33%> (-0.27%)` | `25.00 <1.00> (+2.00)` | :arrow_down: |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `10.91%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 40.70% -10.92%
+ Complexity 3322 2557 -765
=============================================
Files 901 897 -4
Lines 22153 22034 -119
Branches 2118 2111 -7
=============================================
- Hits 11437 8970 -2467
- Misses 9797 12388 +2591
+ Partials 919 676 -243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 179 -722
Lines 22153 4206 -17947
Branches 2118 484 -1634
============================================
- Hits 11437 0 -11437
+ Misses 9797 4206 -5591
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [867 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `17.73%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 33.89% -17.74%
+ Complexity 3322 2162 -1160
=============================================
Files 901 879 -22
Lines 22153 21426 -727
Branches 2118 2046 -72
=============================================
- Hits 11437 7262 -4175
- Misses 9797 13609 +3812
+ Partials 919 555 -364
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [277 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
>
> Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
The above code is only
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
>
> Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
Do you have any other ideas? This PR comes from support for online flow pressure measurement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-711136249
> I am a little confused about this plugin. Could you consider simply providing `ContextManagerExtendService`'s extension? It could create an extension of `TracingContext`.
>
> Then, could add new logic into `TracingContext#extract` w/o changing any core level code.
>
> Make sense?
no problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.84%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.47% +0.84%
- Complexity 3322 3365 +43
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11588 +151
+ Misses 9797 9567 -230
- Partials 919 928 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <8.33%> (-0.27%)` | `25.00 <1.00> (+2.00)` | :arrow_down: |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7b2a0b4dac7ba32ca380c945b4110f3c781dfbd3?el=desc) will **decrease** coverage by `27.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 53.12% 26.12% -27.01%
+ Complexity 3391 1487 -1904
=============================================
Files 880 720 -160
Lines 21957 17879 -4078
Branches 2089 1624 -465
=============================================
- Hits 11665 4671 -6994
- Misses 9361 12870 +3509
+ Partials 931 338 -593
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/core/metric/promethues/rule/CounterFunction.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9Db3VudGVyRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/library/util/prometheus/metrics/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL0dhdWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [418 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [7b2a0b4...b5b592d](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 168 -733
Lines 22153 3992 -18161
Branches 2118 453 -1665
============================================
- Hits 11437 0 -11437
+ Misses 9797 3992 -5805
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [877 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 177 -724
Lines 22153 4094 -18059
Branches 2118 463 -1655
============================================
- Hits 11437 0 -11437
+ Misses 9797 4094 -5703
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [868 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.60%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.22% +0.60%
- Complexity 3322 3368 +46
============================================
Files 901 901
Lines 22153 22193 +40
Branches 2118 2113 -5
============================================
+ Hits 11437 11591 +154
+ Misses 9797 9671 -126
- Partials 919 931 +12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `55.55% <0.00%> (-22.23%)` | `2.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 182 -719
Lines 22153 4269 -17884
Branches 2118 491 -1627
============================================
- Hits 11437 0 -11437
+ Misses 9797 4269 -5528
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-711133693
@wu-sheng thx for review this version. I have extracted the dangerous behavior to the optional plugin. If this behavior is tolerated, I will modify the doc and add the unit test later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.83%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.45% +0.83%
- Complexity 3322 3365 +43
============================================
Files 901 897 -4
Lines 22153 22092 -61
Branches 2118 2117 -1
============================================
+ Hits 11437 11589 +152
+ Misses 9797 9570 -227
- Partials 919 933 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `8.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 42.62% -9.00%
+ Complexity 3322 2652 -670
============================================
Files 901 895 -6
Lines 22153 22075 -78
Branches 2118 2101 -17
============================================
- Hits 11437 9410 -2027
- Misses 9797 11978 +2181
+ Partials 919 687 -232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `13.60%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 38.02% -13.61%
+ Complexity 3322 2423 -899
=============================================
Files 901 896 -5
Lines 22153 21948 -205
Branches 2118 2093 -25
=============================================
- Hits 11437 8346 -3091
- Misses 9797 12966 +3169
+ Partials 919 636 -283
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [219 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.56% +0.94%
- Complexity 3322 3373 +51
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11609 +172
+ Misses 9797 9545 -252
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `50.27% <8.33%> (+0.81%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...7bd8307](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `10.91%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 40.70% -10.92%
+ Complexity 3322 2557 -765
=============================================
Files 901 897 -4
Lines 22153 22034 -119
Branches 2118 2111 -7
=============================================
- Hits 11437 8970 -2467
- Misses 9797 12388 +2591
+ Partials 919 676 -243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `16.38%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 35.24% -16.39%
+ Complexity 3322 2306 -1016
=============================================
Files 901 896 -5
Lines 22153 21929 -224
Branches 2118 2093 -25
=============================================
- Hits 11437 7729 -3708
- Misses 9797 13625 +3828
+ Partials 919 575 -344
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 175 -726
Lines 22153 4139 -18014
Branches 2118 476 -1642
============================================
- Hits 11437 0 -11437
+ Misses 9797 4139 -5658
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [870 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `12.04%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 39.58% -12.05%
+ Complexity 3322 2541 -781
=============================================
Files 901 901
Lines 22153 22180 +27
Branches 2118 2113 -5
=============================================
- Hits 11437 8780 -2657
- Misses 9797 12755 +2958
+ Partials 919 645 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `10.09%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 41.52% -10.10%
+ Complexity 3322 2610 -712
=============================================
Files 901 901
Lines 22153 22180 +27
Branches 2118 2113 -5
=============================================
- Hits 11437 9211 -2226
- Misses 9797 12286 +2489
+ Partials 919 683 -236
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `20.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 31.41% -20.22%
+ Complexity 3322 2036 -1286
=============================================
Files 901 878 -23
Lines 22153 21530 -623
Branches 2118 2051 -67
=============================================
- Hits 11437 6763 -4674
- Misses 9797 14273 +4476
+ Partials 919 494 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `17.74%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 33.88% -17.75%
+ Complexity 3322 2206 -1116
=============================================
Files 901 896 -5
Lines 22153 21905 -248
Branches 2118 2092 -26
=============================================
- Hits 11437 7422 -4015
- Misses 9797 13924 +4127
+ Partials 919 559 -360
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [264 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.87%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.50% +0.87%
- Complexity 3322 3369 +47
============================================
Files 901 897 -4
Lines 22153 22092 -61
Branches 2118 2117 -1
============================================
+ Hits 11437 11599 +162
+ Misses 9797 9561 -236
- Partials 919 932 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699961399
> The key issue is, injecting this has high-security and memory/network/backend overload concerns. We should carefully reconsider how to do this. Personally, I still prefer an API or a pure optional plugin. The key point is, asking users to activate this manually, then we could set up documentation with it to tell users, note the security issue.
@wu-sheng there are some ideas about supporting it in an optional way.
step 1:
refactor some codes of the span behavior:
1. define a new span callback interface for service loader
2. define a span filter chain to process span behavior, such as extract for the carrier or inject to carrier
3. the order of the span filter chain triggered is ordered by the number of callback interfaces.
step 2:
supports correlation behavior by filter chain:
1. the default correlation behavior is only propagate
2. the optional behavior will add an injection behavior, the code way is to add a filter rather than override to ensure the stability of the main process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699808236
@wu-sheng @kezhenxu94 Do you think the MD5 algorithm needs to be modified?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
>
> Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
Do you have any other ideas? This PR comes from support for online flow pressure measurement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 165 -736
Lines 22153 3960 -18193
Branches 2118 451 -1667
============================================
- Hits 11437 0 -11437
+ Misses 9797 3960 -5837
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [879 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#discussion_r507053324
##########
File path: apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/MD5Util.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.util;
+
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class MD5Util {
+ /**
+ * 16 Bit MD5
+ */
+ public static String md516BitUpper(String string) {
+ return md5(string).substring(8, 24).toUpperCase();
+ }
+
+ /**
+ * 32 Bit MD5
+ */
+ public static String md532BitUpper(String string) {
+ return md5(string).toUpperCase();
+ }
+
+ private static String md5(final String string) {
+ try {
+ MessageDigest md = MessageDigest.getInstance("MD5");
Review comment:
*opt.semgrep.java.lang.security.audit.crypto.weak-hash.use-of-md5:* Detected MD5 hash algorithm which is considered insecure. MD5 is not
collision resistant and is therefore not suitable as a cryptographic
signature. Use SHA256 or SHA3 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `9.16%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 42.46% -9.17%
+ Complexity 3322 2635 -687
============================================
Files 901 897 -4
Lines 22153 22089 -64
Branches 2118 2117 -1
============================================
- Hits 11437 9380 -2057
- Misses 9797 12025 +2228
+ Partials 919 684 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [180 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7b2a0b4dac7ba32ca380c945b4110f3c781dfbd3?el=desc) will **decrease** coverage by `24.44%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 53.12% 28.68% -24.45%
+ Complexity 3391 1666 -1725
=============================================
Files 880 737 -143
Lines 21957 18358 -3599
Branches 2089 1670 -419
=============================================
- Hits 11665 5266 -6399
- Misses 9361 12724 +3363
+ Partials 931 368 -563
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/core/metric/promethues/rule/CounterFunction.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9Db3VudGVyRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/library/util/prometheus/metrics/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL0dhdWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [384 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [7b2a0b4...b5b592d](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.60%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.22% +0.60%
- Complexity 3322 3368 +46
============================================
Files 901 901
Lines 22153 22193 +40
Branches 2118 2113 -5
============================================
+ Hits 11437 11591 +154
+ Misses 9797 9671 -126
- Partials 919 931 +12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `55.55% <0.00%> (-22.23%)` | `2.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `16.53%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 35.09% -16.54%
+ Complexity 3322 2234 -1088
=============================================
Files 901 878 -23
Lines 22153 21530 -623
Branches 2118 2051 -67
=============================================
- Hits 11437 7555 -3882
- Misses 9797 13409 +3612
+ Partials 919 566 -353
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [256 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.56% +0.94%
- Complexity 3322 3373 +51
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11609 +172
+ Misses 9797 9545 -252
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `50.27% <8.33%> (+0.81%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.87%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.50% +0.87%
- Complexity 3322 3369 +47
============================================
Files 901 897 -4
Lines 22153 22092 -61
Branches 2118 2117 -1
============================================
+ Hits 11437 11599 +162
+ Misses 9797 9561 -236
- Partials 919 932 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
>
> Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
Do you have any other ideas? This PR comes from support for online flow pressure measurement.
1. At the moment, correlation is just propagation.
2. The current requirement is that sometimes need to inject span.
3. some usages are online traffic staining and tenant traffic discrimination.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.56% +0.94%
- Complexity 3322 3373 +51
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11609 +172
+ Misses 9797 9545 -252
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `50.27% <8.33%> (+0.81%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.52%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.15% +0.52%
- Complexity 3322 3369 +47
============================================
Files 901 1607 +706
Lines 22153 34158 +12005
Branches 2118 3721 +1603
============================================
+ Hits 11437 17815 +6378
- Misses 9797 15476 +5679
+ Partials 919 867 -52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `67.50% <20.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `59.21% <42.30%> (+46.00%)` | `6.00 <2.00> (+2.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.17% <66.66%> (+25.36%)` | `14.00 <1.00> (+1.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `70.58% <70.58%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `57.95% <75.00%> (+14.93%)` | `17.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `71.27% <92.85%> (+21.82%)` | `25.00 <1.00> (+2.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `5.55% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7b2a0b4dac7ba32ca380c945b4110f3c781dfbd3?el=desc) will **decrease** coverage by `24.56%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 53.12% 28.56% -24.57%
+ Complexity 3391 1622 -1769
=============================================
Files 880 720 -160
Lines 21957 17879 -4078
Branches 2089 1624 -465
=============================================
- Hits 11665 5107 -6558
- Misses 9361 12409 +3048
+ Partials 931 363 -568
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/core/metric/promethues/rule/CounterFunction.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9Db3VudGVyRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/library/util/prometheus/metrics/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL0dhdWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [7b2a0b4...b5b592d](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.87%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.50% +0.87%
- Complexity 3322 3369 +47
============================================
Files 901 897 -4
Lines 22153 22092 -61
Branches 2118 2117 -1
============================================
+ Hits 11437 11599 +162
+ Misses 9797 9561 -236
- Partials 919 932 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 169 -732
Lines 22153 4018 -18135
Branches 2118 453 -1665
============================================
- Hits 11437 0 -11437
+ Misses 9797 4018 -5779
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [876 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7b2a0b4dac7ba32ca380c945b4110f3c781dfbd3?el=desc) will **decrease** coverage by `24.44%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 53.12% 28.68% -24.45%
+ Complexity 3391 1666 -1725
=============================================
Files 880 737 -143
Lines 21957 18358 -3599
Branches 2089 1670 -419
=============================================
- Hits 11665 5266 -6399
- Misses 9361 12724 +3363
+ Partials 931 368 -563
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/core/metric/promethues/rule/CounterFunction.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9Db3VudGVyRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/library/util/prometheus/metrics/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL0dhdWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [384 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [7b2a0b4...b5b592d](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 162 -739
Lines 22153 3935 -18218
Branches 2118 449 -1669
============================================
- Hits 11437 0 -11437
+ Misses 9797 3935 -5862
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [880 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `8.36%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 43.26% -8.37%
+ Complexity 3322 2677 -645
============================================
Files 901 897 -4
Lines 22153 22092 -61
Branches 2118 2117 -1
============================================
- Hits 11437 9558 -1879
- Misses 9797 11847 +2050
+ Partials 919 687 -232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [158 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#discussion_r495667530
##########
File path: apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/MD5Util.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.util;
+
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class MD5Util {
+ /**
+ * 16 Bit MD5 RSA
+ */
+ public static String md516BitUpper(String string) {
+ return md5(string).substring(8, 24).toUpperCase();
+ }
+
+ /**
+ * 32 Bit MD5 RSA
+ */
+ public static String md532BitUpper(String string) {
+ return md5(string).toUpperCase();
+ }
+
+ private static String md5(final String string) {
+ try {
+ MessageDigest md = MessageDigest.getInstance("MD5");
Review comment:
*BAD_HEXA_CONVERSION:* Leading zeros are omitted in the concatenation increasing collision potential [(details)](https://find-sec-bugs.github.io/bugs.htm#BAD_HEXA_CONVERSION)
##########
File path: apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/MD5Util.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.util;
+
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class MD5Util {
+ /**
+ * 16 Bit MD5 RSA
+ */
+ public static String md516BitUpper(String string) {
+ return md5(string).substring(8, 24).toUpperCase();
+ }
+
+ /**
+ * 32 Bit MD5 RSA
+ */
+ public static String md532BitUpper(String string) {
+ return md5(string).toUpperCase();
+ }
+
+ private static String md5(final String string) {
+ try {
+ MessageDigest md = MessageDigest.getInstance("MD5");
Review comment:
*WEAK_MESSAGE_DIGEST_MD5:* This API MD5 (MDX) is not a recommended cryptographic hash function [(details)](https://find-sec-bugs.github.io/bugs.htm#WEAK_MESSAGE_DIGEST_MD5)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.56% +0.94%
- Complexity 3322 3373 +51
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11609 +172
+ Misses 9797 9545 -252
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `50.27% <8.33%> (+0.81%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `9.41%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 42.20% -9.42%
+ Complexity 3322 2635 -687
============================================
Files 901 901
Lines 22153 22180 +27
Branches 2118 2113 -5
============================================
- Hits 11437 9362 -2075
- Misses 9797 12136 +2339
+ Partials 919 682 -237
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [188 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 171 -730
Lines 22153 4009 -18144
Branches 2118 453 -1665
============================================
- Hits 11437 0 -11437
+ Misses 9797 4009 -5788
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [874 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `9.58%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 42.04% -9.59%
+ Complexity 3322 2603 -719
============================================
Files 901 897 -4
Lines 22153 22051 -102
Branches 2118 2112 -6
============================================
- Hits 11437 9271 -2166
- Misses 9797 12101 +2304
+ Partials 919 679 -240
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp removed a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp removed a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699961399
> The key issue is, injecting this has high-security and memory/network/backend overload concerns. We should carefully reconsider how to do this. Personally, I still prefer an API or a pure optional plugin. The key point is, asking users to activate this manually, then we could set up documentation with it to tell users, note the security issue.
@wu-sheng there are some ideas about supporting it in an optional way.
step 1:
refactor some codes of the span behavior:
1. define a new span callback interface for service loader
2. define a span filter chain to process span behavior, such as extract for the carrier or inject to carrier
3. the order of the span filter chain triggered is ordered by the number of callback interfaces.
step 2:
supports correlation behavior by filter chain:
1. the default correlation behavior is only propagate
2. the optional behavior will add an injection behavior, the code way is to add a filter rather than override to ensure the stability of the main process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `9.56%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 42.06% -9.57%
+ Complexity 3322 2604 -718
============================================
Files 901 897 -4
Lines 22153 22061 -92
Branches 2118 2112 -6
============================================
- Hits 11437 9279 -2158
- Misses 9797 12103 +2306
+ Partials 919 679 -240
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [175 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `16.39%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 35.23% -16.40%
+ Complexity 3322 2305 -1017
=============================================
Files 901 896 -5
Lines 22153 21929 -224
Branches 2118 2093 -25
=============================================
- Hits 11437 7726 -3711
- Misses 9797 13626 +3829
+ Partials 919 577 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 170 -731
Lines 22153 4003 -18150
Branches 2118 453 -1665
============================================
- Hits 11437 0 -11437
+ Misses 9797 4003 -5794
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699911682
The key issue is, injecting this has high-security and memory/network/backend overload concerns. We should carefully reconsider how to do this. Personally, I still prefer an API or a pure optional plugin. The key point is, asking users to activate this manually, then we could set up documentation with it to tell users, note the security issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp closed pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp closed pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 175 -726
Lines 22153 4155 -17998
Branches 2118 479 -1639
============================================
- Hits 11437 0 -11437
+ Misses 9797 4155 -5642
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [870 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
>
> Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
Do you have any other ideas? This PR comes from support for online flow pressure measurement.
1. At the moment, correlation is just propagation.
2. The current requirement is that sometimes need to inject span.
3. some usages are online traffic staining and tenant traffic discrimination.
Another idea to ensure safety :
we only support inject tags name by external passing to label the traffic source.
the passing value: sw-correlation: base64(tagName):base64(token)
The tagName must be configured in the agent.conf.
Or we only support hard code k:v config propagate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `9.67%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 41.95% -9.68%
+ Complexity 3322 2631 -691
============================================
Files 901 895 -6
Lines 22153 22075 -78
Branches 2118 2101 -17
============================================
- Hits 11437 9262 -2175
- Misses 9797 12129 +2332
+ Partials 919 684 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `51.62%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
- Coverage 51.62% 0.00% -51.63%
============================================
Files 901 174 -727
Lines 22153 4067 -18086
Branches 2118 459 -1659
============================================
- Hits 11437 0 -11437
+ Misses 9797 4067 -5730
+ Partials 919 0 -919
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [871 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699834711
MD5 thing is not the thing we should discuss, please read above comments. That is the key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `13.84%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 37.78% -13.85%
+ Complexity 3322 2376 -946
=============================================
Files 901 878 -23
Lines 22153 21546 -607
Branches 2118 2053 -65
=============================================
- Hits 11437 8141 -3296
- Misses 9797 12788 +2991
+ Partials 919 617 -302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [236 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.48% +0.85%
- Complexity 3322 3362 +40
============================================
Files 901 895 -6
Lines 22153 22075 -78
Branches 2118 2101 -17
============================================
+ Hits 11437 11585 +148
+ Misses 9797 9561 -236
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <8.33%> (-0.27%)` | `25.00 <1.00> (+2.00)` | :arrow_down: |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.48% +0.85%
- Complexity 3322 3364 +42
============================================
Files 901 895 -6
Lines 22153 22077 -76
Branches 2118 2103 -15
============================================
+ Hits 11437 11587 +150
+ Misses 9797 9561 -236
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <8.33%> (-0.27%)` | `25.00 <1.00> (+2.00)` | :arrow_down: |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `43.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.56% +0.94%
- Complexity 3322 3373 +51
============================================
Files 901 895 -6
Lines 22153 22083 -70
Branches 2118 2116 -2
============================================
+ Hits 11437 11609 +172
+ Misses 9797 9545 -252
- Partials 919 929 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `50.27% <8.33%> (+0.81%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.34% <66.66%> (+2.32%)` | `17.00 <0.00> (ø)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `22.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 29.45% -22.18%
+ Complexity 3322 1902 -1420
=============================================
Files 901 878 -23
Lines 22153 21456 -697
Branches 2118 2045 -73
=============================================
- Hits 11437 6319 -5118
- Misses 9797 14665 +4868
+ Partials 919 472 -447
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...09b3d1a](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **decrease** coverage by `10.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
=============================================
- Coverage 51.62% 40.63% -11.00%
+ Complexity 3322 2548 -774
=============================================
Files 901 896 -5
Lines 22153 21962 -191
Branches 2118 2094 -24
=============================================
- Hits 11437 8924 -2513
- Misses 9797 12371 +2574
+ Partials 919 667 -252
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-43.03%)` | `0.00 <0.00> (-17.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-13.21%)` | `0.00 <0.00> (-4.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (-23.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `0.00% <0.00%> (-39.82%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.46%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.09% +0.46%
- Complexity 3322 3368 +46
============================================
Files 901 1608 +707
Lines 22153 34167 +12014
Branches 2118 3714 +1596
============================================
+ Hits 11437 17800 +6363
- Misses 9797 15501 +5704
+ Partials 919 866 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `67.50% <20.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `59.21% <42.30%> (+46.00%)` | `6.00 <2.00> (+2.00)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.17% <66.66%> (+25.36%)` | `14.00 <1.00> (+1.00)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `70.58% <70.58%> (ø)` | `4.00 <4.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `57.95% <75.00%> (+14.93%)` | `17.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `71.27% <92.85%> (+21.82%)` | `25.00 <1.00> (+2.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `5.55% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1107 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
>
> Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
Do you have any other ideas? This PR comes from support for online flow pressure measurement.
1. At the moment, correlation is just propagation.
2. The current requirement is that sometimes need to inject span.
3. some usages are online traffic staining and tenant traffic discrimination.
Another idea to ensure safety :
we only support inject tags name by external passing to label the traffic source.
the passing value: sw-correlation: base64(tagName):base64(token)
The tagName must be configured in the agent.conf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=h1) Report
> Merging [#5571](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/806666b4cc7df864d3f20796ec9a171151e72c0e?el=desc) will **increase** coverage by `0.86%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5571 +/- ##
============================================
+ Coverage 51.62% 52.48% +0.86%
- Complexity 3322 3366 +44
============================================
Files 901 897 -4
Lines 22153 22092 -61
Branches 2118 2117 -1
============================================
+ Hits 11437 11596 +159
+ Misses 9797 9564 -233
- Partials 919 932 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.73% <7.14%> (+0.28%)` | `25.00 <1.00> (+2.00)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `21.33% <34.61%> (+8.12%)` | `6.00 <2.00> (+2.00)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `45.45% <62.50%> (+2.43%)` | `17.00 <0.00> (ø)` | |
| [...n/java/org/apache/skywalking/apm/util/MD5Util.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvTUQ1VXRpbC5qYXZh) | `64.70% <64.70%> (ø)` | `4.00 <4.00> (?)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `40.54% <66.66%> (+0.72%)` | `14.00 <1.00> (+1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.32% <100.00%> (+0.66%)` | `0.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=footer). Last update [806666b...1b4f29b](https://codecov.io/gh/apache/skywalking/pull/5571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-711134223
> Do you think the MD5 algorithm needs to be modified?
Back to this, MD5 could be replaced by BASE64, basically in the open-source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5571: inject span tags from correlation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699733760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org