You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/12 19:51:25 UTC
[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9840: [Relay/Frontend][TFLite] Change the output shape calculation based on keep_dim option in fully connected
AndrewZhaoLuo commented on a change in pull request #9840:
URL: https://github.com/apache/tvm/pull/9840#discussion_r783397015
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -1911,6 +1911,14 @@ def convert_fully_connected(self, op):
weight_expr = self.exp_tab.new_const(weight_value, dtype=weight_tensor_type_str)
weight_shape = _infer_shape(weight_expr)
+ # Change the output shape calculation based on keep_dim option
Review comment:
Maybe try converting from keras?
https://www.tensorflow.org/api_docs/python/tf/keras/layers/Dense
Its documentated behavior seems to match keep_dims = True.
I would make just a new unit test if you go this route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org