[GitHub] [cassandra] adelapena commented on a diff in pull request #2193: CASSANDRA-17940: CEP-20: Dynamic Data Masking

["adelapena (via GitHub)" <gi...@apache.org>]

adelapena commented on code in PR #2193:
URL: https://github.com/apache/cassandra/pull/2193#discussion_r1142095818


##########
src/java/org/apache/cassandra/cql3/statements/schema/DropFunctionStatement.java:
##########
@@ -120,6 +120,14 @@ public Keyspaces apply(Keyspaces schema)
         if (!dependentAggregates.isEmpty())
             throw ire("Function '%s' is still referenced by aggregates %s", name, dependentAggregates);
 
+        String dependentTables =

Review Comment:
   I've copied the aligning of `dependentAggregates` right above. Do you want me to change it to:
   ```java
           String dependentTables = keyspace.tablesUsingFunction(function)
                                            .map(table -> table.name)
                                            .collect(joining(", "));
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org