[GitHub] [celix] pnoltes commented on a diff in pull request #409: Feature/rename zmq and jansson targets to align with conan

[GitBox <gi...@apache.org>]

pnoltes commented on code in PR #409:
URL: https://github.com/apache/celix/pull/409#discussion_r843174692


##########
cmake/Modules/Findczmq.cmake:
##########
@@ -37,14 +37,14 @@ set(CZMQ_INCLUDE_DIRS ${CZMQ_INCLUDE_DIR} )
 include(FindPackageHandleStandardArgs)
 # handle the QUIETLY and REQUIRED arguments and set CZMQ_FOUND to TRUE
 # if all listed variables are TRUE
-find_package_handle_standard_args(CZMQ  DEFAULT_MSG
+find_package_handle_standard_args(czmq  DEFAULT_MSG
                                   CZMQ_LIBRARY CZMQ_INCLUDE_DIR)
 
 mark_as_advanced(CZMQ_INCLUDE_DIR CZMQ_LIBRARY)
 
-if (CZMQ_FOUND AND NOT TARGET CZMQ::lib)
-    add_library(CZMQ::lib SHARED IMPORTED)
-    set_target_properties(CZMQ::lib PROPERTIES
+if (CZMQ_FOUND AND NOT TARGET czmq::czmq)
+    add_library(czmq::czmq SHARED IMPORTED)

Review Comment:
   Yes, I forgot this one. I will also re-enable the C++ RSA for the build server. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org