You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2021/05/15 10:17:09 UTC

[pulsar] branch master updated: Fix sink/source exception stats (#10549)

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 5b73495  Fix sink/source exception stats (#10549)
5b73495 is described below

commit 5b734953d8e6ad9e7b08a372460c4c9bc86e6056
Author: linlinnn <li...@163.com>
AuthorDate: Sat May 15 18:16:26 2021 +0800

    Fix sink/source exception stats (#10549)
    
    Fixes #10546
    
    ### Motivation
    fix sink/source exception stats
---
 .../apache/pulsar/functions/instance/stats/SinkStatsManager.java  | 8 +++++++-
 .../pulsar/functions/instance/stats/SourceStatsManager.java       | 6 ++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SinkStatsManager.java b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SinkStatsManager.java
index 46999cd..255ad62 100644
--- a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SinkStatsManager.java
+++ b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SinkStatsManager.java
@@ -229,6 +229,9 @@ public class SinkStatsManager extends ComponentStatsManager {
 
     @Override
     public void incrSysExceptions(Throwable ex) {
+        _statTotalSysExceptions.inc();
+        _statTotalSysExceptions1min.inc();
+
         long ts = System.currentTimeMillis();
         InstanceCommunication.FunctionStatus.ExceptionInformation info = getExceptionInfo(ex, ts);
         latestSystemExceptions.add(info);
@@ -252,6 +255,9 @@ public class SinkStatsManager extends ComponentStatsManager {
 
     @Override
     public void incrSinkExceptions(Throwable ex) {
+        _statTotalSinkExceptions.inc();
+        _statTotalSinkExceptions1min.inc();
+
         long ts = System.currentTimeMillis();
         InstanceCommunication.FunctionStatus.ExceptionInformation info = getExceptionInfo(ex, ts);
         latestSinkExceptions.add(info);
@@ -276,7 +282,7 @@ public class SinkStatsManager extends ComponentStatsManager {
 
     @Override
     public void processTimeStart() {
-        //no-p[
+        //no-op
     }
 
     @Override
diff --git a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SourceStatsManager.java b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SourceStatsManager.java
index e79e0b5..f900625 100644
--- a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SourceStatsManager.java
+++ b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/stats/SourceStatsManager.java
@@ -228,6 +228,9 @@ public class SourceStatsManager extends ComponentStatsManager {
 
     @Override
     public void incrSysExceptions(Throwable ex) {
+        _statTotalSysExceptions.inc();
+        _statTotalSysExceptions1min.inc();
+
         long ts = System.currentTimeMillis();
         InstanceCommunication.FunctionStatus.ExceptionInformation info = getExceptionInfo(ex, ts);
         latestSystemExceptions.add(info);
@@ -246,6 +249,9 @@ public class SourceStatsManager extends ComponentStatsManager {
 
     @Override
     public void incrSourceExceptions(Throwable ex) {
+        _statTotalSourceExceptions.inc();
+        _statTotalSourceExceptions1min.inc();
+
         long ts = System.currentTimeMillis();
         InstanceCommunication.FunctionStatus.ExceptionInformation info = getExceptionInfo(ex, ts);
         latestSourceExceptions.add(info);