You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "rkirtir (via GitHub)" <gi...@apache.org> on 2023/08/18 02:47:54 UTC
[GitHub] [hive] rkirtir commented on a diff in pull request #4497: HIVE-23680 : TestDbNotificationListener is unstable
rkirtir commented on code in PR #4497:
URL: https://github.com/apache/hive/pull/4497#discussion_r1297929807
##########
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java:
##########
@@ -251,18 +248,6 @@ public void onInsert(InsertEvent insertEvent) throws MetaException {
pushEventId(EventType.INSERT, insertEvent);
}
- public void onOpenTxn(OpenTxnEvent openTxnEvent) throws MetaException {
- pushEventId(EventType.OPEN_TXN, openTxnEvent);
- }
-
- public void onCommitTxn(CommitTxnEvent commitTxnEvent) throws MetaException {
- pushEventId(EventType.COMMIT_TXN, commitTxnEvent);
- }
-
- public void onAbortTxn(AbortTxnEvent abortTxnEvent) throws MetaException {
- pushEventId(EventType.ABORT_TXN, abortTxnEvent);
- }
-
Review Comment:
As all transactional tests methods moved to other class, this has been removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org