You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kocolosk <gi...@git.apache.org> on 2015/07/18 13:53:54 UTC
[GitHub] couchdb-couch pull request: Ensure doc groups are sorted before me...
GitHub user kocolosk opened a pull request:
https://github.com/apache/couchdb-couch/pull/76
Ensure doc groups are sorted before merging them
We had been implicily assuming that clients send us sorted groups, but unsurprisingly that's not always the case. The additional sorting here should be redundant, but the consequences of merging unsorted groups are severe -- we can end up with uniqueness violations on the primary key in the database -- and so we add an additional sort here.
COUCHDB-2735
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch 2735-duplicate-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit cb4f1aa073a6add3b4a6215ab2d253bff8e8c961
Author: Adam Kocoloski <ad...@cloudant.com>
Date: 2015-07-18T11:49:00Z
Ensure doc groups are sorted before merging them
We had been implicily assuming that clients send us sorted groups, but
unsurprisingly that's not always the case. The additional sorting here
should be redundant, but the consequences of merging unsorted groups are
severe -- we can end up with uniqueness violations on the primary key in
the database -- and so we add an additional sort here.
COUCHDB-2735
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Ensure doc groups are sorted before me...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/76#issuecomment-122534929
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Ensure doc groups are sorted before me...
Posted by kocolosk <gi...@git.apache.org>.
Github user kocolosk commented on the pull request:
https://github.com/apache/couchdb-couch/pull/76#issuecomment-122557626
Fixing a typo in the commit message and merging, thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Ensure doc groups are sorted before me...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---