You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/14 11:26:03 UTC
[GitHub] [iceberg] nastra opened a new pull request, #5985: Core: Optimize code in TableScanContext
nastra opened a new pull request, #5985:
URL: https://github.com/apache/iceberg/pull/5985
This is a shorter alternative to #5982 but technically it breaks backwards-compatibility because we don't have a no-arg constructor anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #5985: Core: Make TableScanContext immutable
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #5985:
URL: https://github.com/apache/iceberg/pull/5985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #5985: Core: Make TableScanContext immutable
Posted by GitBox <gi...@apache.org>.
nastra commented on PR #5985:
URL: https://github.com/apache/iceberg/pull/5985#issuecomment-1281842312
> +1 for the refactoring refactoring. is builder also generated by the annotation?
yes the Builder is also being generated by the Immutables library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zinking commented on pull request #5985: Core: Make TableScanContext immutable
Posted by GitBox <gi...@apache.org>.
zinking commented on PR #5985:
URL: https://github.com/apache/iceberg/pull/5985#issuecomment-1281703735
+1 for the refactoring refactoring.
is builder also generated by the annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #5985: Core: Make TableScanContext immutable
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #5985:
URL: https://github.com/apache/iceberg/pull/5985#issuecomment-1524624706
I will go ahead to merge this to unblock #5984, and mark Liwei as coauthor to close #5982. Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org