You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "JohnZp (via GitHub)" <gi...@apache.org> on 2024/07/17 07:24:16 UTC

[PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

JohnZp opened a new pull request, #16336:
URL: https://github.com/apache/dolphinscheduler/pull/16336

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Purpose of the pull request
   
   #16331 
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   ## Pull Request Notice
   [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #16336:
URL: https://github.com/apache/dolphinscheduler/pull/16336#issuecomment-2330493635

   > e.g.
   > /dolphinscheduler/tenant1/resources/spark/xx.jar
   > /dolphinscheduler/tenant2/resources/spark/yy.jar
   
   For this case, I think we can keep `tenant1/resources/spark/xx.jar` for user is enough.
   
   Are you still working on this? @JohnZp 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

Posted by "JohnZp (via GitHub)" <gi...@apache.org>.
JohnZp closed pull request #16336: [Fix-16331] fix the resource file cannot be displayed hierarchically
URL: https://github.com/apache/dolphinscheduler/pull/16336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #16336:
URL: https://github.com/apache/dolphinscheduler/pull/16336#issuecomment-2235047366

   > Do I need to resubmit?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16336:
URL: https://github.com/apache/dolphinscheduler/pull/16336#discussion_r1680588846


##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/bin/start.sh:
##########
@@ -22,7 +22,7 @@ DOLPHINSCHEDULER_HOME=$(cd ${BIN_DIR}/..;pwd)
 
 source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"
 
-JVM_ARGS_ENV_FILE=${BIN_DIR}/bin/jvm_args_env.sh
+JVM_ARGS_ENV_FILE=${DOLPHINSCHEDULER_HOME}/bin/jvm_args_env.sh

Review Comment:
   Please avoid unnessnary change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

Posted by "JohnZp (via GitHub)" <gi...@apache.org>.
JohnZp commented on PR #16336:
URL: https://github.com/apache/dolphinscheduler/pull/16336#issuecomment-2235018316

   > LGTM, but please make the CI happy.
   > 
   > ```
   > mvn spotless:apply
   > ```
   Do I need to resubmit?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-16331] fix the resource file cannot be displayed hierarchically [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #16336: [Fix-16331] fix the resource file cannot be displayed hierarchically
URL: https://github.com/apache/dolphinscheduler/pull/16336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org