You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/12/19 18:55:30 UTC

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22246


Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................

IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

This patch change the thread in PeriodicCounterUpdater from
boost::thread to impala:Thread. Using impala::Thread and
impala::Thread::Create will make both instance_>update_thread_ and
system_instance_>update_thread_ observable through '/threadz' page in
WebUI.

Testing:
- Run test_tpcds_queries.py and confirm the is no abnormality observed.
- Confirm that both 'periodic-counter-updater' and
  'periodic-system-counter-updater' shows up in '/threadz' page.

Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
---
M be/src/util/periodic-counter-updater.cc
M be/src/util/periodic-counter-updater.h
2 files changed, 9 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22246/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17738/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2024 19:33:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22246/1/be/src/util/periodic-counter-updater.h
File be/src/util/periodic-counter-updater.h:

http://gerrit.cloudera.org:8080/#/c/22246/1/be/src/util/periodic-counter-updater.h@22
PS1, Line 22: #include <unordered_set>
            : 
            : #include "util/runtime-profile.h"
            : #include "util/thread.h"
            : 
> All of this can be removed, I think.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2024 19:07:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Dec 2024 15:55:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17737/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2024 19:21:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22246/1/be/src/util/periodic-counter-updater.h
File be/src/util/periodic-counter-updater.h:

http://gerrit.cloudera.org:8080/#/c/22246/1/be/src/util/periodic-counter-updater.h@22
PS1, Line 22: #include <boost/function.hpp>
            : #include <boost/scoped_ptr.hpp>
            : #include <boost/thread/thread.hpp>
            : #include <boost/unordered_map.hpp>
            : #include <boost/unordered_set.hpp>
All of this can be removed, I think.



-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2024 19:00:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11227/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Dec 2024 15:55:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Dec 2024 21:27:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22246

to look at the new patch set (#2).

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................

IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

This patch change the thread in PeriodicCounterUpdater from
boost::thread to impala:Thread. Using impala::Thread and
impala::Thread::Create will make both instance_>update_thread_ and
system_instance_>update_thread_ observable through '/threadz' page in
WebUI.

Replaced all boost include with std in periodic-counter-updater.h.

Testing:
- Run test_tpcds_queries.py and confirm the is no abnormality observed.
- Confirm that both 'periodic-counter-updater' and
  'periodic-system-counter-updater' shows up in '/threadz' page.

Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
---
M be/src/util/periodic-counter-updater.cc
M be/src/util/periodic-counter-updater.h
2 files changed, 14 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22246/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Dec 2024 12:39:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22246 )

Change subject: IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater
......................................................................

IMPALA-13628: Use impala::Thread in PeriodicCounterUpdater

This patch change the thread in PeriodicCounterUpdater from
boost::thread to impala:Thread. Using impala::Thread and
impala::Thread::Create will make both instance_>update_thread_ and
system_instance_>update_thread_ observable through '/threadz' page in
WebUI.

Replaced all boost include with std in periodic-counter-updater.h.

Testing:
- Run test_tpcds_queries.py and confirm the is no abnormality observed.
- Confirm that both 'periodic-counter-updater' and
  'periodic-system-counter-updater' shows up in '/threadz' page.

Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Reviewed-on: http://gerrit.cloudera.org:8080/22246
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/periodic-counter-updater.cc
M be/src/util/periodic-counter-updater.h
2 files changed, 14 insertions(+), 16 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b04fe7818726832c520425ee29c9732cc100cb2
Gerrit-Change-Number: 22246
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>