[GitHub] [camel-k] nicolaferraro commented on a change in pull request #2535: Fix #2530: fix type and do not add cross-namespace owner references

[GitBox <gi...@apache.org>]

nicolaferraro commented on a change in pull request #2535:
URL: https://github.com/apache/camel-k/pull/2535#discussion_r678967157



##########
File path: pkg/trait/pull_secret.go
##########
@@ -122,6 +122,10 @@ func (t *pullSecretTrait) newImagePullerRoleBinding(e *Environment) *rbacv1.Role
 		serviceAccount = "default"
 	}
 	return &rbacv1.RoleBinding{

Review comment:
       Right, previously the resource was created directly by the trait, but a [recent change](https://github.com/apache/camel-k/commit/17cf52fc72a518fe44506ae97514a32ed444ce1c#diff-ffe17df62455fe57d1838af003526f25a73d77e84e950fdb275ea162e7699d96L114-L131) made it pass from the trait cycle, so it got updated in the owner trait.
   
   I think it's ok to attach them to the integrationplatform, +1.
   
   The problem with multiple sas is real.. To simplify things, we can use a different naming convention, attaching the name of the service account to the rolebinding's name (rather than managing multiple subjects), so that we can have multiple ones without issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org