You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2025/12/10 23:03:43 UTC
[PR] improve segment cache mount/unmount resilience if interrupted (druid)
clintropolis opened a new pull request, #18833:
URL: https://github.com/apache/druid/pull/18833
### Description
Added a test for vsf mode segment cache that is interrupted while trying to perform lazy loading, which could result in some errors due to partially set state without the updated changes to mount/unmount in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] improve segment cache mount/unmount resilience if interrupted (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #18833:
URL: https://github.com/apache/druid/pull/18833#discussion_r2608566354
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -1069,14 +1069,17 @@
try {
synchronized (this) {
if (referenceProvider != null) {
- referenceProvider.close();
+ ReferenceCountedSegmentProvider provider = referenceProvider;
referenceProvider = null;
+ provider.close();
}
if (!config.isDeleteOnRemove()) {
return;
}
if (storageDir != null) {
- atomicMoveAndDeleteCacheEntryDirectory(storageDir);
+ if (storageDir.exists()) {
Review Comment:
## Uncontrolled data used in path expression
This path depends on a [user-provided value](1).
[Show more details](https://github.com/apache/druid/security/code-scanning/10583)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] improve segment cache mount/unmount resilience if interrupted (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #18833:
URL: https://github.com/apache/druid/pull/18833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org