You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/09/12 08:37:09 UTC

svn commit: r1881651 - /pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java

Author: tilman
Date: Sat Sep 12 08:37:08 2020
New Revision: 1881651

URL: http://svn.apache.org/viewvc?rev=1881651&view=rev
Log:
PDFBOX-4892: refactor

Modified:
    pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java

Modified: pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java?rev=1881651&r1=1881650&r2=1881651&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java Sat Sep 12 08:37:08 2020
@@ -762,8 +762,6 @@ public final class PDAcroForm implements
      */
     private boolean resolveNeedsTranslation(PDAppearanceStream appearanceStream)
     {
-        boolean needsTranslation = true;
-
         PDResources resources = appearanceStream.getResources();
         if (resources != null && resources.getXObjectNames().iterator().hasNext())
         {
@@ -783,7 +781,7 @@ public final class PDAcroForm implements
                         float llY = bbox.getLowerLeftY();
                         if (Float.compare(llX, 0) != 0 && Float.compare(llY, 0) != 0)
                         {
-                            needsTranslation = false;
+                            return false;
                         }
                     }
                 }
@@ -793,9 +791,10 @@ public final class PDAcroForm implements
                     // as this might only cause a misplacement
                 }
             }
-            return needsTranslation;
         }
-        
+
+        // a field without specific settings typically needs to be translated
+        // to the correct position
         return true;
     }